Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): singleton function: access runtime, log group and configure layers and environment #17372

Conversation

ryparker
Copy link
Contributor

@ryparker ryparker commented Nov 5, 2021

Summary

This PR adds the following to SingletonFunction:

  • runtime - property
  • logGroup - property
  • addLayers() - method
  • addEnvironment() - method

Fixes: #17369


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 5, 2021

@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Nov 5, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 5, 2021
@ryparker ryparker requested a review from nija-at November 5, 2021 23:30
@ryparker ryparker assigned ryparker and unassigned comcalvi Nov 5, 2021
@ryparker ryparker removed the request for review from nija-at November 5, 2021 23:32
@ryparker ryparker added @aws-cdk/aws-lambda Related to AWS Lambda and removed @aws-cdk/aws-logs Related to Amazon CloudWatch Logs labels Nov 5, 2021
@ryparker ryparker requested a review from nija-at November 5, 2021 23:35
@ryparker ryparker removed their assignment Nov 5, 2021
@github-actions github-actions bot added the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Nov 5, 2021
@ryparker ryparker removed the @aws-cdk/aws-logs Related to Amazon CloudWatch Logs label Nov 5, 2021
@ryparker ryparker assigned nija-at and unassigned comcalvi Nov 5, 2021
@ryparker ryparker added the pr-linter/exempt-readme The PR linter will not require README changes label Nov 5, 2021
@nija-at nija-at changed the title feat(aws-lambda/SingletonFunction): Add runtime, logGroup, addLayers(), addEnvironment() feat(lambda): singleton function: access runtime, log group and configure layers and environment Nov 9, 2021
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Nov 9, 2021
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment around docs. Rest look good.

Once fixed, remove the 'do-not-merge' label.

packages/@aws-cdk/aws-lambda/lib/singleton-lambda.ts Outdated Show resolved Hide resolved
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@ryparker ryparker removed the pr/do-not-merge This PR should not be merged at this time. label Nov 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: ea10b7a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ec5b102 into master Nov 9, 2021
@mergify mergify bot deleted the aws-lambda-add-additional-properties-and-methods-to-singletonfunction branch November 9, 2021 21:10
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…gure layers and environment (aws#17372)

## Summary

This PR adds the following to `SingletonFunction`:

- `runtime` - property
- `logGroup` - property
- `addLayers()` - method
- `addEnvironment()` - method

Fixes: aws#17369

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda contribution/core This is a PR that came from AWS. pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-lambda): Add additional properties & methods to SingletonFunction
4 participants