Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: the assertions module is now stable! #17395

Merged
merged 3 commits into from
Nov 8, 2021
Merged

feat: the assertions module is now stable! #17395

merged 3 commits into from
Nov 8, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Nov 8, 2021

In addition, fix up CDKv2 init templates to not refer to the alpha
version of this module.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

feat: The assertions module is now stable!
3b1805e 
In addition, fix up CDKv2 init templates to not refer to the alpha
version of this module.
@nija-at nija-at requested review from rix0rrr, njlynch, corymhall and a team November 8, 2021 13:32
@nija-at nija-at self-assigned this Nov 8, 2021
@gitpod-io
Copy link

gitpod-io bot commented Nov 8, 2021

@github-actions github-actions bot added the @aws-cdk/assertions Related to the @aws-cdk/assertv2 package label Nov 8, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 8, 2021
@nija-at
Copy link
Contributor Author

nija-at commented Nov 8, 2021

@njlynch - Besides changing the stability and maturity keys in package.json, anything else needs to be done to graduate an alpha module to stable in CDKv2?

@nija-at
Copy link
Contributor Author

nija-at commented Nov 8, 2021

@corymhall - I believe these are all the references to assertions alpha in the init templates. Let me know if I missed anything.

@nija-at nija-at changed the title feat: The assertions module is now stable! feat: the assertions module is now stable! Nov 8, 2021
@nija-at nija-at added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes and removed pr-linter/exempt-readme The PR linter will not require README changes labels Nov 8, 2021
@njlynch
Copy link
Contributor

njlynch commented Nov 8, 2021

Besides changing the stability and maturity keys in package.json, anything else needs to be done to graduate an alpha module to stable in CDKv2?

I believe we'll also need to update the UbergenPackageVisibility rules:

https://github.com/aws/aws-cdk/blob/master/tools/%40aws-cdk/pkglint/lib/rules.ts#L1586-L1603

@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Nov 8, 2021
@eladb
Copy link
Contributor

eladb commented Nov 8, 2021

🚀 Congrats!

@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Nov 8, 2021
@nija-at nija-at marked this pull request as ready for review November 8, 2021 16:03
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 65298e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ede5e22 into master Nov 8, 2021
@mergify mergify bot deleted the nija-at/assertions-stable branch November 8, 2021 16:51
@mergify
Copy link
Contributor

mergify bot commented Nov 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@TikiTDO
feat: the assertions module is now stable! (aws#17395)
3dacccb 
In addition, fix up CDKv2 init templates to not refer to the alpha
version of this module.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njlynch njlynch njlynch approved these changes

@rix0rrr rix0rrr rix0rrr approved these changes

@corymhall corymhall Awaiting requested review from corymhall

Assignees

@nija-at nija-at

Labels
@aws-cdk/assertions Related to the @aws-cdk/assertv2 package contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nija-at @njlynch @eladb @aws-cdk-automation @rix0rrr