Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-codebuild): add @aws-cdk/asserts to package deps #17435

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

ryparker
Copy link
Contributor

@ryparker ryparker commented Nov 9, 2021

Summary

This PR adds @aws-cdk/asserts to the dependency list of aws-codebuild.

Fixes: #17416


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 9, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 9, 2021
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label Nov 9, 2021
@ryparker ryparker added the pr-linter/exempt-test The PR linter will not require test changes label Nov 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c69376c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9c77e94 into master Nov 9, 2021
@mergify mergify bot deleted the fix-codebuild-assert-package-dep branch November 9, 2021 21:49
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
## Summary

This PR adds `@aws-cdk/asserts` to the dependency list of `aws-codebuild`. 

Fixes:  aws#17416

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(@aws-cdk/aws-events-targets): doesn't provide @aws-cdk/assets, breaking dependency of @aws-cdk/aws-codebuild
4 participants