feat(cloudwatch): expose dashboardName property on the L2 Dashboard construct #17721
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-cloudwatch
NetaNir
added
pr-linter/exempt-readme
| @@ -108,6 +113,8 @@ export class Dashboard extends Resource { | |||
| }), | |||
| }); | |||
|
|
|||
| this.dashboardName = dashboard.dashboardName; | |||
There was a problem hiding this comment.
Since the dashboard name is the resource physicalName you need to use getResourceNameAttribute .
This will ensure that if a name is not passed the Ref value will be used (and resolved at deploy time).
Take a look at examples such as S3 bucketName, autoscaling autoScalingGroupName
| @@ -161,6 +161,21 @@ describe('Dashboard', () => { | |||
|
|
|||
| }); | |||
|
|
|||
| test('DashboardName is exposed correctly when provided', () => { | |||
There was a problem hiding this comment.
This tests is redundant, If this member visibility change it will be caught by the API compatibility check.
I have marked the PR as no test required so it will pass the linter, lets remove this test
mergify
bot
dismissed
NetaNir’s stale review
Pull request has been modified.
Updated on fa90485:
|
|
@NetaNir any updates here? |
| @@ -108,6 +113,9 @@ export class Dashboard extends Resource { | |||
| }), | |||
| }); | |||
|
|
|||
| this.dashboardName = this.getResourceNameAttribute(dashboard.ref); | |||
| // dashboard.dashboardName; | |||
rix0rrr
added
feature-request
mergify
bot
dismissed
madeline-k’s stale review
Pull request has been modified.
madeline-k
added
pr-linter/exempt-readme
TheRealAmazonKendra
added
the
pr-linter/exempt-integ-test
mergify
bot
dismissed
madeline-k’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Exposes
dashboardNameproperty onDashboardconstruct.closes issue #17648
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license