Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): add im4gn and is4gen instances #17780

Merged
merged 7 commits into from
Dec 13, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Nov 30, 2021

Newly announced im4gn and is4gen storage optimized instances:
https://aws.amazon.com/blogs/aws/new-storage-optimized-amazon-ec2-instances-im4gn-and-is4gen-powered-by-aws-graviton2-processors/

image

image

CFN docs have already been updated:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 30, 2021

@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Nov 30, 2021
@robertd
Copy link
Contributor Author

robertd commented Nov 30, 2021

Build currently failing. Probably related to: aws/jsii#3208

error JSII8001: Enum members must be ALL_CAPS. Rename "@aws-cdk/aws-ec2.InstanceClass.IM4GN" to "IM4_G_N"
error JSII8001: Enum members must be ALL_CAPS. Rename "@aws-cdk/aws-ec2.InstanceClass.IS4GEN" to "IS4_GE_N"

@robertd
Copy link
Contributor Author

robertd commented Nov 30, 2021

aws/jsii#3209 landed... so this will probably go away once jsii gets bumped to 1.47.0... whenever that one gets released.

@njlynch njlynch added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Dec 8, 2021
@robertd
Copy link
Contributor Author

robertd commented Dec 8, 2021

Depends on #17904

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c89b26a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e057c8f into aws:master Dec 13, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants