Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appsync): remove 'id' suffix to union definition key #17787

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

BryanPan342
Copy link
Contributor

Removing an unnecessary suffix from union definitions.

Fixes: #17771


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Removing an unnecessary suffix from union definitions.
@gitpod-io
Copy link

gitpod-io bot commented Nov 30, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 30, 2021
@pahud
Copy link
Contributor

pahud commented Dec 1, 2021

Hi @ChenKuanSun what do you think about this? Can you take a peek?

@otaviomacedo otaviomacedo added the pr-linter/exempt-test The PR linter will not require test changes label Dec 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@otaviomacedo otaviomacedo self-assigned this Dec 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d036dd7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 86e7780 into aws:master Dec 6, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 6, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Removing an unnecessary suffix from union definitions.

Fixes: aws#17771 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cdk/aws-appsync): Union type definition fields suffixed with "id"
4 participants