(aws-cdk): After CDK v2 upgrade, my Gitlab CI/CD started failing #17832

robertd · 2021-12-03T16:47:49Z

General Issue

After CDK v2 upgrade, my Gitlab CI/CD started failing

The Question

Hello,

I tarted migrating my CDK v1 repos/apps to CDK v2, and my Gitlab CI/CD pipeline started failing after cdk diff command. I'm not getting any errors when I run ci/cd jobs (on the same runner) with CDK v1. Any input is appreciated.

I did run cdk boostrap beforehand which created new S3 buckets.

Running with gitlab-runner 14.5.1 (de104fcd)
  on it-gitlab-runner-11282021-i-0c0762964cee7b6f3 yiFuzyWh
Preparing the "docker+machine" executor
00:19
Using Docker executor with image code.acme.com:5001/acme/images/alpine-aws-cdk-lib:2.0.0 ...
Authenticating with credentials from job payload (GitLab Registry)
Pulling docker image code.acme.com:5001/acme/images/alpine-aws-cdk-lib:2.0.0 ...
Using docker image sha256:a965de674d4e3fe3cd42ad844710d2d8a4d5fd2df7d98c89e7a17a1dce4dc09c for code.acme.com:5001/acme/images/alpine-aws-cdk-lib:2.0.0 with digest code.acme.com:5001/acme/images/alpine-aws-cdk-lib@sha256:7ce4125cfa6d5d10ce711e6d8671f81bef18c9a7e33f3ec42d789d2dc930bdb0 ...
Preparing environment
00:02
Running on runner-yifuzywh-project-6307-concurrent-0 via runner-yifuzywh-gitlab-runner-1638545703-be16bac1...
Getting source from Git repository
00:01
Fetching changes with git depth set to 50...
Initialized empty Git repository in /builds/acme/cf/cloudfront-factory/.git/
Created fresh repository.
Checking out 4fbc13d7 as v2-main...
Skipping Git submodules setup
Restoring cache
00:09
Checking cache for default...
Downloading cache.zip from https://sc-123456789012-pp-6qq5ww7pf2co-runnercachebucket-yzp20ogu1gd.s3.dualstack.us-west-2.amazonaws.com/project/6307/default 
Successfully extracted cache
Executing "step_script" stage of the job script
01:08
Using docker image sha256:a965de674d4e3fe3cd42ad844710d2d8a4d5fd2df7d98c89e7a17a1dce4dc09c for code.acme.com:5001/acme/images/alpine-aws-cdk-lib:2.0.0 with digest code.acme.com:5001/acme/images/alpine-aws-cdk-lib@sha256:7ce4125cfa6d5d10ce711e6d8671f81bef18c9a7e33f3ec42d789d2dc930bdb0 ...
$ npm install
removed 7 packages, and audited 735 packages in 2s
25 packages are looking for funding
  run `npm fund` for details
found 0 vulnerabilities
$ cdk doctor
ℹ️ CDK Version: 2.0.0 (build 4b6ce31)
ℹ️ AWS environment variables:
  - AWS_DEFAULT_REGION = us-west-2
  - AWS_PAGER = 
  - AWS_STS_REGIONAL_ENDPOINTS = regional
  - AWS_NODEJS_CONNECTION_REUSE_ENABLED = 1
ℹ️ CDK environment variables:
  - CDK_DEFAULT_ACCOUNT = 123456789012
  - CDK_DEFAULT_REGION = us-west-2
$ cp ./cfg/dummy/dummy.cfg.ts ./cfg/selected/config.ts
$ npm run build
> cloudfront-factory@0.1.0 build
> tsc
$ cdk synth --all
Successfully synthesized to /builds/acme/cf/cloudfront-factory/cdk.out
Supply a stack id (dummy-lambda-edge, dummyDynamicCFStack, dummyStaticCFStack) to display its template.
$ cdk list
dummy-lambda-edge
dummyDynamicCFStack
dummyStaticCFStack
$ cdk -vvv diff
CDK toolkit version: 2.0.0 (build 4b6ce31)
Command line arguments: {
  _: [ 'diff' ],
  v: 3,
  verbose: 3,
  defaultAccount: 123456789012,
  defaultRegion: 'us-west-2',
  lookups: true,
  'ignore-errors': false,
  ignoreErrors: false,
  json: false,
  j: false,
  debug: false,
  ec2creds: undefined,
  i: undefined,
  'version-reporting': undefined,
  versionReporting: undefined,
  'path-metadata': true,
  pathMetadata: true,
  'asset-metadata': true,
  assetMetadata: true,
  'role-arn': undefined,
  r: undefined,
  roleArn: undefined,
  staging: true,
  'no-color': false,
  noColor: false,
  'context-lines': 3,
  contextLines: 3,
  strict: false,
  'security-only': false,
  securityOnly: false,
  fail: false,
  '$0': '/usr/local/bin/cdk'
}
cdk.json: {
  "app": "npx ts-node --prefer-ts-exts bin/cloudfront-factory.ts",
  "watch": {
    "include": [
      "**"
    ],
    "exclude": [
      "README.md",
      "cdk*.json",
      "**/*.d.ts",
      "**/*.js",
      "tsconfig.json",
      "package*.json",
      "yarn.lock",
      "node_modules",
      "test"
    ]
  },
  "context": {
    "@aws-cdk/aws-apigateway:usagePlanKeyOrderInsensitiveId": true,
    "@aws-cdk/core:stackRelativeExports": true,
    "@aws-cdk/aws-rds:lowercaseDbIdentifier": true,
    "@aws-cdk/aws-lambda:recognizeVersionProps": true,
    "@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021": true
  }
}
merged settings: {
  versionReporting: true,
  pathMetadata: true,
  output: 'cdk.out',
  app: 'npx ts-node --prefer-ts-exts bin/cloudfront-factory.ts',
  watch: {
    include: [ '**' ],
    exclude: [
      'README.md',
      'cdk*.json',
      '**/*.d.ts',
      '**/*.js',
      'tsconfig.json',
      'package*.json',
      'yarn.lock',
      'node_modules',
      'test'
    ]
  },
  context: {
    '@aws-cdk/aws-apigateway:usagePlanKeyOrderInsensitiveId': true,
    '@aws-cdk/core:stackRelativeExports': true,
    '@aws-cdk/aws-rds:lowercaseDbIdentifier': true,
    '@aws-cdk/aws-lambda:recognizeVersionProps': true,
    '@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021': true
  },
  debug: false,
  assetMetadata: true,
  toolkitBucket: {},
  staging: true,
  bundlingStacks: [ '*' ],
  lookups: true
}
Determining if we're on an EC2 instance.
Looks like an EC2 instance.
Toolkit stack: CDKToolkit
Setting "CDK_DEFAULT_REGION" environment variable to us-west-2
Resolving default credentials
Retrieved account ID 123456789012 from disk cache
Setting "CDK_DEFAULT_ACCOUNT" environment variable to 123456789012
context: {
  '@aws-cdk/aws-apigateway:usagePlanKeyOrderInsensitiveId': true,
  '@aws-cdk/core:stackRelativeExports': true,
  '@aws-cdk/aws-rds:lowercaseDbIdentifier': true,
  '@aws-cdk/aws-lambda:recognizeVersionProps': true,
  '@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021': true,
  'aws:cdk:enable-path-metadata': true,
  'aws:cdk:enable-asset-metadata': true,
  'aws:cdk:version-reporting': true,
  'aws:cdk:bundling-stacks': [ '*' ]
}
outdir: cdk.out
env: {
  CDK_DEFAULT_REGION: 'us-west-2',
  CDK_DEFAULT_ACCOUNT: '123456789012',
  CDK_CONTEXT_JSON: '{"@aws-cdk/aws-apigateway:usagePlanKeyOrderInsensitiveId":true,"@aws-cdk/core:stackRelativeExports":true,"@aws-cdk/aws-rds:lowercaseDbIdentifier":true,"@aws-cdk/aws-lambda:recognizeVersionProps":true,"@aws-cdk/aws-cloudfront:defaultSecurityPolicyTLSv1.2_2021":true,"aws:cdk:enable-path-metadata":true,"aws:cdk:enable-asset-metadata":true,"aws:cdk:version-reporting":true,"aws:cdk:bundling-stacks":["*"]}',
  CDK_OUTDIR: 'cdk.out',
  CDK_CLI_ASM_VERSION: '15.0.0',
  CDK_CLI_VERSION: '2.0.0'
}
Stack dummy-lambda-edge
Reading existing template for stack dummy-lambda-edge.
Retrieved account ID 123456789012 from disk cache
Assuming role 'arn:aws:iam::123456789012:role/cdk-hnb659fds-deploy-role-123456789012-us-east-1'.
[AWS cloudformation 200 0.382s 0 retries] describeStacks({ StackName: 'dummy-lambda-edge' })
[AWS cloudformation 200 0.34s 0 retries] getTemplate({
  StackName: 'dummy-lambda-edge',
  TemplateStage: 'Original'
})
Parameters
[-] Parameter AssetParametersd04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277S3BucketBD00DE50: {"Type":"String","Description":"S3 bucket for asset \"d04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277\""}
[-] Parameter AssetParametersd04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277S3VersionKeyD071EABC: {"Type":"String","Description":"S3 key for asset version \"d04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277\""}
[-] Parameter AssetParametersd04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277ArtifactHash54FC89D7: {"Type":"String","Description":"Artifact hash for asset \"d04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277\""}
[+] Parameter BootstrapVersion BootstrapVersion: {"Type":"AWS::SSM::Parameter::Value<String>","Default":"/cdk-bootstrap/hnb659fds/version","Description":"Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"}
Resources
[-] AWS::Lambda::Version dummylambdaedge0CurrentVersion743479E7e3d55a6f9667647a064264ae04e4d212 destroy
[+] AWS::Lambda::Version dummy-lambda-edge-0/CurrentVersion dummylambdaedge0CurrentVersion743479E7c5fef02dd39b1e206b38c386cafab30a 
[~] AWS::Lambda::Function dummy-lambda-edge-0 dummylambdaedge085A8E25C 
 └─ [~] Code
     ├─ [~] .S3Bucket:
     │   └─ @@ -1,3 +1,1 @@
     │      [-] {
     │      [-]   "Ref": "AssetParametersd04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277S3BucketBD00DE50"
     │      [-] }
     │      [+] "cdk-hnb659fds-assets-123456789012-us-east-1"
     └─ [~] .S3Key:
         └─ @@ -1,33 +1,1 @@
            [-] {
            [-]   "Fn::Join": [
            [-]     "",
            [-]     [
            [-]       {
            [-]         "Fn::Select": [
            [-]           0,
            [-]           {
            [-]             "Fn::Split": [
            [-]               "||",
            [-]               {
            [-]                 "Ref": "AssetParametersd04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277S3VersionKeyD071EABC"
            [-]               }
            [-]             ]
            [-]           }
            [-]         ]
            [-]       },
            [-]       {
            [-]         "Fn::Select": [
            [-]           1,
            [-]           {
            [-]             "Fn::Split": [
            [-]               "||",
            [-]               {
            [-]                 "Ref": "AssetParametersd04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277S3VersionKeyD071EABC"
            [-]               }
            [-]             ]
            [-]           }
            [-]         ]
            [-]       }
            [-]     ]
            [-]   ]
            [-] }
            [+] "d04c3782a3848dfcb10b99bbf4fe32595222026fbae524406c10d7c52c2b9277.zip"
[~] AWS::SSM::Parameter dummy-lambda-edge-0/Parameter dummylambdaedge0ParameterA3A1A1CE 
 └─ [~] Value
     └─ [~] .Ref:
         ├─ [-] dummylambdaedge0CurrentVersion743479E7e3d55a6f9667647a064264ae04e4d212
         └─ [+] dummylambdaedge0CurrentVersion743479E7c5fef02dd39b1e206b38c386cafab30a
Other Changes
[+] Unknown Rules: {"CheckBootstrapVersion":{"Assertions":[{"Assert":{"Fn::Not":[{"Fn::Contains":[["1","2","3","4","5"],{"Ref":"BootstrapVersion"}]}]},"AssertDescription":"CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."}]}}
Stack dummyDynamicCFStack
Reading existing template for stack dummyDynamicCFStack.
Retrieved account ID 123456789012 from disk cache
Assuming role 'arn:aws:iam::123456789012:role/cdk-hnb659fds-deploy-role-123456789012-us-west-2'.
[AWS cloudformation 200 0.148s 0 retries] describeStacks({ StackName: 'dummyDynamicCFStack' })
[AWS cloudformation 200 0.123s 0 retries] getTemplate({ StackName: 'dummyDynamicCFStack', TemplateStage: 'Original' })
Parameters
[+] Parameter BootstrapVersion BootstrapVersion: {"Type":"AWS::SSM::Parameter::Value<String>","Default":"/cdk-bootstrap/hnb659fds/version","Description":"Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"}
Other Changes
[+] Unknown Rules: {"CheckBootstrapVersion":{"Assertions":[{"Assert":{"Fn::Not":[{"Fn::Contains":[["1","2","3","4","5"],{"Ref":"BootstrapVersion"}]}]},"AssertDescription":"CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."}]}}
Stack dummyStaticCFStack
Reading existing template for stack dummyStaticCFStack.
Retrieved account ID 123456789012 from disk cache
Assuming role 'arn:aws:iam::123456789012:role/cdk-hnb659fds-deploy-role-123456789012-us-west-2'.
[AWS cloudformation 200 0.177s 0 retries] describeStacks({ StackName: 'dummyStaticCFStack' })
[AWS cloudformation 200 0.118s 0 retries] getTemplate({
  StackName: 'dummyStaticCFStack',
  TemplateStage: 'Original'
})
Parameters
[-] Parameter AssetParameters45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241S3BucketF1BC72A7: {"Type":"String","Description":"S3 bucket for asset \"45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241\""}
[-] Parameter AssetParameters45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241S3VersionKey7AD83AC7: {"Type":"String","Description":"S3 key for asset version \"45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241\""}
[-] Parameter AssetParameters45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241ArtifactHash1B3D1B80: {"Type":"String","Description":"Artifact hash for asset \"45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241\""}
[+] Parameter BootstrapVersion BootstrapVersion: {"Type":"AWS::SSM::Parameter::Value<String>","Default":"/cdk-bootstrap/hnb659fds/version","Description":"Version of the CDK Bootstrap resources in this environment, automatically retrieved from SSM Parameter Store. [cdk:skip]"}
Resources
[~] Custom::CrossRegionStringParameterReader dummy-lambda-edge-0/ArnReader dummylambdaedge0ArnReader1406476B 
 └─ [~] RefreshToken
     ├─ [-] dummylambdaedge0CurrentVersion743479E7e3d55a6f9667647a064264ae04e4d212
     └─ [+] dummylambdaedge0CurrentVersion743479E7c5fef02dd39b1e206b38c386cafab30a
[~] AWS::Lambda::Function Custom::CrossRegionStringParameterReaderCustomResourceProvider/Handler CustomCrossRegionStringParameterReaderCustomResourceProviderHandler65B5F33A 
 └─ [~] Code
     ├─ [~] .S3Bucket:
     │   └─ @@ -1,3 +1,1 @@
     │      [-] {
     │      [-]   "Ref": "AssetParameters45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241S3BucketF1BC72A7"
     │      [-] }
     │      [+] "cdk-hnb659fds-assets-123456789012-us-west-2"
     └─ [~] .S3Key:
         └─ @@ -1,33 +1,1 @@
            [-] {
            [-]   "Fn::Join": [
            [-]     "",
            [-]     [
            [-]       {
            [-]         "Fn::Select": [
            [-]           0,
            [-]           {
            [-]             "Fn::Split": [
            [-]               "||",
            [-]               {
            [-]                 "Ref": "AssetParameters45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241S3VersionKey7AD83AC7"
            [-]               }
            [-]             ]
            [-]           }
            [-]         ]
            [-]       },
            [-]       {
            [-]         "Fn::Select": [
            [-]           1,
            [-]           {
            [-]             "Fn::Split": [
            [-]               "||",
            [-]               {
            [-]                 "Ref": "AssetParameters45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241S3VersionKey7AD83AC7"
            [-]               }
            [-]             ]
            [-]           }
            [-]         ]
            [-]       }
            [-]     ]
            [-]   ]
            [-] }
            [+] "45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241.zip"
Other Changes
[+] Unknown Rules: {"CheckBootstrapVersion":{"Assertions":[{"Assert":{"Fn::Not":[{"Fn::Contains":[["1","2","3","4","5"],{"Ref":"BootstrapVersion"}]}]},"AssertDescription":"CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."}]}}
Cleaning up project directory and file based variables
00:00
ERROR: Job failed: exit code 1

CDK CLI Version

2.0.0 (build 4b6ce31)

Framework Version

No response

Node.js Version

v16.13.1

OS

OSx 11.6.1 Big Sur

Language

Typescript

Language Version

3.9.7

Other information

No response

The text was updated successfully, but these errors were encountered:

robertd · 2021-12-03T16:51:46Z

Gitlab CI/CD is using the alpine container with aws-cdk, aws-cli, python and few other things...

FROM node:lts-alpine

LABEL maintainer="robertd"

ENV AWSCDK_VERSION=2.0.0
ENV GLIBC_VER=2.34-r0
# override aws-cli v2 default pager
ENV AWS_PAGER=""

RUN apk update && apk upgrade
RUN apk add --no-cache --update python3 python3-dev git jq

#pip3 needs to be run initialy to upgrade pip
RUN python3 -m ensurepip
RUN pip3 install --upgrade pip
RUN pip3 install boto3 \
  json-spec \
  yamllint

# https://github.com/aws/aws-cli/issues/4685#issuecomment-615872019
# install glibc compatibility for alpine
RUN apk --no-cache add \
        binutils \
        curl \
    && curl -sL https://alpine-pkgs.sgerrand.com/sgerrand.rsa.pub -o /etc/apk/keys/sgerrand.rsa.pub \
    && curl -sLO https://github.com/sgerrand/alpine-pkg-glibc/releases/download/${GLIBC_VER}/glibc-${GLIBC_VER}.apk \
    && curl -sLO https://github.com/sgerrand/alpine-pkg-glibc/releases/download/${GLIBC_VER}/glibc-bin-${GLIBC_VER}.apk \
    && apk add --no-cache \
        glibc-${GLIBC_VER}.apk \
        glibc-bin-${GLIBC_VER}.apk \
    && curl -sL https://awscli.amazonaws.com/awscli-exe-linux-x86_64.zip -o awscliv2.zip \
    && unzip awscliv2.zip \
    && aws/install \
    && rm -rf \
        awscliv2.zip \
        aws \
        /usr/local/aws-cli/v2/*/dist/aws_completer \
        /usr/local/aws-cli/v2/*/dist/awscli/data/ac.index \
        /usr/local/aws-cli/v2/*/dist/awscli/examples \
    && apk --no-cache del \
        binutils \
        curl \
    && rm glibc-${GLIBC_VER}.apk \
    && rm glibc-bin-${GLIBC_VER}.apk \
    && rm -rf /var/cache/apk/*

RUN npm i -g npm
RUN npm i -g aws-cdk@${AWSCDK_VERSION}

robertd · 2021-12-04T06:08:09Z

Upon further tinkering and adding CI_DEBUG_TRACE: "true" to gitlab runner, I noticed that cdk diff command doesn't return 0 anymore.

cdk 2.x

$ cdk diff
...
            [-]             ]
            [-]           }
            [-]         ]
            [-]       }
            [-]     ]
            [-]   ]
            [-] }
            [+] "45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241.zip"
Other Changes
[+] Unknown Rules: {"CheckBootstrapVersion":{"Assertions":[{"Assert":{"Fn::Not":[{"Fn::Contains":[["1","2","3","4","5"],{"Ref":"BootstrapVersion"}]}]},"AssertDescription":"CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."}]}}
Cleaning up project directory and file based variables
00:01 
+ set -eo pipefail
+ set +o noclobber
+ eval '$'\''rm'\'' "-f" "/builds/acme/cf/cloudfront-factory.tmp/CI_SERVER_TLS_CA_FILE"
'
+ :
++ rm -f /builds/acme/cf/cloudfront-factory.tmp/CI_SERVER_TLS_CA_FILE
+ exit 0
ERROR: Job failed: exit code 1

cdk 1.x

$ cdk diff
Stack acmeStaticCFStack
Resources
[~] AWS::CloudFront::Distribution distro distro40218A07 
 └─ [~] DistributionConfig
     ├─ [~] .Aliases:
     │   └─ @@ -1,4 +1,4 @@
     │      [ ] [
     │      [-]   "acme.com",
     │      [+]   "baz.com"
     │      [ ] ]
     └─ [~] .Comment:
         ├─ [-] Static distro for acme.
         └─ [+] Static distro for baz.
+ exit 0
Saving cache for successful job
+ set -eo pipefail
+ set +o noclobber
+ :
+ eval '$'\''rm'\'' "-f" "/builds/acme/cf/cloudfront-factory.tmp/CI_SERVER_TLS_CA_FILE"
'
++ rm -f /builds/acme/cf/cloudfront-factory.tmp/CI_SERVER_TLS_CA_FILE
+ exit 0
Job succeeded

It seems that in v2 PR addressing this issue (#4650) either got reverted or the bug got reintroduced. @jogold Would you mind taking a peek and providing your take on this issue?

robertd · 2021-12-04T06:30:05Z

After adding cdk diff || true pipeline completed, so it's definitely a regression.

            [-]     ]
            [-]   ]
            [-] }
            [+] "45b7ed524ce2b119dd4f2b8642ae8bfaf0df45bc6bd705072ae4ee6d1a999241.zip"
Other Changes
[+] Unknown Rules: {"CheckBootstrapVersion":{"Assertions":[{"Assert":{"Fn::Not":[{"Fn::Contains":[["1","2","3","4","5"],{"Ref":"BootstrapVersion"}]}]},"AssertDescription":"CDK bootstrap stack version 6 required. Please run 'cdk bootstrap' with a recent version of the CDK CLI."}]}}
+ true
+ exit 0
Saving cache for successful job
00:11
+ set -eo pipefail
+ set +o noclobber
+ :
+ eval '$'\''rm'\'' "-f" "/builds/acme/cf/cloudfront-factory.tmp/CI_SERVER_TLS_CA_FILE"
'
++ rm -f /builds/acme/cf/cloudfront-factory.tmp/CI_SERVER_TLS_CA_FILE
+ exit 0
Job succeeded

njlynch · 2021-12-06T12:57:02Z

You're correct. The way our CLI handled expired feature flags (like aws-cdk:enableDiffNoFail) was inconsistent with how the CDK library behavior; the latter correctly defaulted any expired feature flags to true, whereas the former defaulted to the (currently incorrect) "default" value, which was false.

Fix is #17862

robertd · 2021-12-06T13:36:34Z

Thank for confirming this @njlynch. And thanks for providing the PR for it. Much appreciated. 👍 😊

njlynch · 2021-12-06T16:03:09Z

Fix will go out with next v2 release.

github-actions · 2021-12-06T16:03:36Z

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

robertd added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Dec 3, 2021

github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Dec 3, 2021

github-actions bot assigned rix0rrr Dec 3, 2021

njlynch mentioned this issue Dec 6, 2021

fix(aws-cdk): cdk diff always fails on diff #17862

Merged

njlynch closed this as completed Dec 6, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

(aws-cdk): After CDK v2 upgrade, my Gitlab CI/CD started failing #17832

(aws-cdk): After CDK v2 upgrade, my Gitlab CI/CD started failing #17832

robertd commented Dec 3, 2021

robertd commented Dec 3, 2021 •

edited

Loading

robertd commented Dec 4, 2021 •

edited

Loading

robertd commented Dec 4, 2021 •

edited

Loading

njlynch commented Dec 6, 2021

robertd commented Dec 6, 2021

njlynch commented Dec 6, 2021

github-actions bot commented Dec 6, 2021

(aws-cdk): After CDK v2 upgrade, my Gitlab CI/CD started failing #17832

(aws-cdk): After CDK v2 upgrade, my Gitlab CI/CD started failing #17832

Comments

robertd commented Dec 3, 2021

General Issue

The Question

CDK CLI Version

Framework Version

Node.js Version

OS

Language

Language Version

Other information

robertd commented Dec 3, 2021 • edited Loading

robertd commented Dec 4, 2021 • edited Loading

robertd commented Dec 4, 2021 • edited Loading

njlynch commented Dec 6, 2021

robertd commented Dec 6, 2021

njlynch commented Dec 6, 2021

github-actions bot commented Dec 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

robertd commented Dec 3, 2021 •

edited

Loading

robertd commented Dec 4, 2021 •

edited

Loading

robertd commented Dec 4, 2021 •

edited

Loading