Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-ec2): add g4ad instance types #17927

Merged
merged 5 commits into from
Dec 30, 2021

Conversation

cokia
Copy link
Contributor

@cokia cokia commented Dec 9, 2021

update EC2 instance type for g4ad series.

AWS CFN docs have already been updated:

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-instance.html#cfn-ec2-instance-instancetype

closes #17565

@gitpod-io
Copy link

gitpod-io bot commented Dec 9, 2021

@mergify
Copy link
Contributor

mergify bot commented Dec 9, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Dec 9, 2021
@cokia cokia changed the title Update EC2 instance type for g4ad fix(aws-ec2): update EC2 instance type for g4ad Dec 13, 2021
@cokia
Copy link
Contributor Author

cokia commented Dec 14, 2021

@njlynch
Please Check.There is no test case to be changed.

@njlynch njlynch changed the title fix(aws-ec2): update EC2 instance type for g4ad feat(aws-ec2): add g4ad instance types Dec 30, 2021
@njlynch njlynch added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes labels Dec 30, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f59ebb6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8cb6a76 into aws:master Dec 30, 2021
@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(ec2): InstanceClass missing G4AD type
3 participants