Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanse output of cdk doctor from known/probable credentials #1795

Closed
RomainMuller opened this issue Feb 19, 2019 · 2 comments
Closed

Cleanse output of cdk doctor from known/probable credentials #1795

RomainMuller opened this issue Feb 19, 2019 · 2 comments
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. ops-excellence Operational Excellence p1 package/tools Related to AWS CDK Tools or CLI

Comments

@RomainMuller
Copy link
Contributor

The output of cdk doctor will list all environment variables with a name starting with AWS_ as those might influence the workings of the application.

We need to redact the values for the environment variables known to be used for credentials, as well as probably any environment variable name that looks passwords-y (contains "password", or "pass", or "passwd", for example).
@RomainMuller RomainMuller added security feature-request A feature should be added or improved. ops-excellence Operational Excellence labels Feb 19, 2019
@fulghum fulghum added p1 package/tools Related to AWS CDK Tools or CLI labels Mar 6, 2019
@statik statik mentioned this issue Aug 6, 2019
Merged
@shivlaks
Copy link
Contributor

shivlaks commented Oct 7, 2019

#2357 redacted the AWS_ACCESS_KEY.

Still outstanding:

  • redacting keys that have a name which might be secrets-ish

@shivlaks shivlaks added the effort/small Small work item – less than a day of effort label Feb 6, 2020
@NGL321 NGL321 assigned rix0rrr and unassigned shivlaks Jan 25, 2021
@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. ops-excellence Operational Excellence p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fulghum @RomainMuller @rix0rrr @shivlaks