fix(rds): unable to use tokens as port in DatabaseInstance
#17995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-rds
skinny85
previously requested changes
Dec 13, 2021
| @@ -746,7 +746,7 @@ abstract class DatabaseInstanceNew extends DatabaseInstanceBase implements IData | |||
| performanceInsightsRetentionPeriod: enablePerformanceInsights | |||
| ? (props.performanceInsightRetention || PerformanceInsightRetention.DEFAULT) | |||
| : undefined, | |||
| port: props.port?.toString(), | |||
| port: props.port ? Tokenization.stringifyNumber(props.port) : undefined, | |||
There was a problem hiding this comment.
Two things:
- I think you want the condition to be
props.port === undefined, as 0 is falsy in JavaScript. - I believe you can use
Token.toString(props.port)instead - it's more of the idiomatic way to do it (Tokenizationis more of an internal class).
There was a problem hiding this comment.
- Good catch. 0 is a valid port number. I changed it.
- Method
Token.toString()doesn't accept an attribute. So I can't use it. Should I try something else? Or isTokenization.stringifyNumber(props.port)the only way to handle it?
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
In `DatabaseInstance` the port number can be specified using data type number. If a token value (e.g. CloudFormation Parameter) was used here, the token was not resolved correctly. The conversion of property `port` has been corrected by using method `Tokenization.stringifyNumber()`. Fixes aws#17948. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
DatabaseInstancethe port number can be specified using data type number.If a token value (e.g. CloudFormation Parameter) was used here, the token was not resolved correctly.
The conversion of property
porthas been corrected by using methodTokenization.stringifyNumber().Fixes #17948.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license