feat(codepipeline): variables for CodeStar Connections source Action #18086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
kornicameister
force-pushed
the
fix_17807
branch
3 times, most recently
from
69a37ae to
891c647
Compare
|
@skinny85 no idea what I am doing wrong with semantic pull request. I think it follows the guideline but apparently I am missing an important detail |
skinny85
changed the title
github-actions
bot
added
the
@aws-cdk/aws-codepipeline
skinny85
previously requested changes
Dec 20, 2021
There was a problem hiding this comment.
Looks great @kornicameister! A few tiny comments before we merge this in, but this is in great shape already.
packages/@aws-cdk/aws-codepipeline-actions/lib/codestar-connections/source-action.ts
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
|
On holiday now. I will try to get back to it after Xmas but I cannot promise that. |
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
Adds `variables` method that allows to retrieve action's [variables](https://docs.aws.amazon.com/codepipeline/latest/userguide/reference-variables.html) using type safe approach. With that we can rely on compiler to pick up incorrect access instead of hacking it with plain strings. fixes: aws#17807
kornicameister
force-pushed
the
fix_17807
branch
from
14a3f9e to
78c70d4
Compare
|
@skinny85 ready for another round. |
|
Looks like the linter is failing the build: |
|
Yeah, it wasn't picked by |
skinny85
previously requested changes
Dec 28, 2021
There was a problem hiding this comment.
Looks great @kornicameister! A few suggestions on the test, that I will address myself.
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
...ws-codepipeline-actions/test/codestar-connections/codestar-connections-source-action.test.ts
Outdated
Show resolved
Hide resolved
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
skinny85
previously approved these changes
Dec 29, 2021
skinny85
reviewed
Dec 29, 2021
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
skinny85
previously approved these changes
Dec 29, 2021
mergify
bot
dismissed
skinny85’s stale review
Pull request has been modified.
skinny85
approved these changes
Dec 29, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ws#18086) Adds `variables` method that allows to retrieve action's [variables](https://docs.aws.amazon.com/codepipeline/latest/userguide/reference-variables.html) using type safe approach. With that we can rely on compiler to pick up incorrect access instead of hacking it with plain strings. fixes: aws#17807 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
variablesmethod that allows to retrieve action's variablesusing type safe approach.
With that we can rely on compiler to pick up incorrect access instead
of hacking it with plain strings.
fixes: #17807
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license