feat(iot): Action to send messages to SQS queues #18087

dyoshikawa · 2021-12-19T07:16:47Z

Fixes #17699

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2021-12-19T07:16:50Z

mergify · 2021-12-19T07:17:22Z

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

skinny85 · 2021-12-20T18:54:25Z

@dyoshikawa is this ready for a review, or are you still working on it?

dyoshikawa · 2021-12-28T05:37:04Z

Sorry, I working now, so not ready for review.

dyoshikawa · 2021-12-31T15:24:25Z

@skinny85 Ready for review now.

skinny85

Looks great @dyoshikawa! I have one major comment about naming, and then a few minor ones, but this is great.

skinny85 · 2022-01-04T00:32:12Z

packages/@aws-cdk/aws-iot-actions/README.md

+const stream = new firehose.DeliveryStream(this, 'MyStream', {
+  destinations: [new destinations.S3Bucket(bucket)],
+});


Why does this example contain a Firehose DeliveryStream? It's not used anywhere from what I can see.

Thank you. I fixed.

skinny85 · 2022-01-04T00:34:22Z

packages/@aws-cdk/aws-iot-actions/lib/sqs-queue-action.ts

+/**
+ * Configuration properties of an action for s3.
+ */
+export interface SQSQueueActionProps extends CommonActionProps {


We camel-case acronyms in CDK:

Suggested change

export interface SQSQueueActionProps extends CommonActionProps {

export interface SqsQueueActionProps extends CommonActionProps {

Thank you. I fixed.

skinny85 · 2022-01-04T00:36:23Z

packages/@aws-cdk/aws-iot-actions/lib/sqs-queue-action.ts

+/**
+ * The action to write the data from an MQTT message to an Amazon SQS queue.
+ */
+export class SQSQueueAction implements iot.IAction {


Suggested change

export class SQSQueueAction implements iot.IAction {

export class SqsQueueAction implements iot.IAction {

Thank you. I fixed.

skinny85 · 2022-01-04T00:39:19Z

packages/@aws-cdk/aws-iot-actions/test/sqs/integ.sqs-queue-action.ts

+    topicRule.addAction(
+      new actions.SQSQueueAction(queue),
+    );


Suggested change

topicRule.addAction(

new actions.SQSQueueAction(queue),

);

topicRule.addAction(new actions.SQSQueueAction(queue));

Thank you. I fixed.

skinny85 · 2022-01-04T00:40:06Z

packages/@aws-cdk/aws-iot-actions/test/sqs/sqs-queue-action.test.ts

+import * as cdk from '@aws-cdk/core';
+import * as actions from '../../lib';
+
+test('Default sqs queue action', () => {


Suggested change

test('Default sqs queue action', () => {

test('Default SQS queue action', () => {

Thank you. I fixed.

packages/@aws-cdk/aws-iot-actions/test/sqs/sqs-queue-action.test.ts

skinny85 · 2022-01-04T00:42:40Z

packages/@aws-cdk/aws-iot-actions/test/sqs/sqs-queue-action.test.ts

+  topicRule.addAction(
+    new actions.SQSQueueAction(queue),
+  );


Suggested change

topicRule.addAction(

new actions.SQSQueueAction(queue),

);

topicRule.addAction(new actions.SQSQueueAction(queue));

Thank you. I fixed.

skinny85 · 2022-01-04T00:43:38Z

packages/@aws-cdk/aws-iot-actions/test/sqs/sqs-queue-action.test.ts

+  topicRule.addAction(
+    new actions.SQSQueueAction(queue, {
+      useBase64: true,
+    }),
+  );


Suggested change

topicRule.addAction(

new actions.SQSQueueAction(queue, {

useBase64: true,

}),

);

topicRule.addAction(new actions.SQSQueueAction(queue, {

useBase64: true,

}));

Thank you. I fixed.

skinny85 · 2022-01-04T00:43:56Z

packages/@aws-cdk/aws-iot-actions/test/sqs/sqs-queue-action.test.ts

+  topicRule.addAction(
+    new actions.SQSQueueAction(queue, { role }),
+  );


Suggested change

topicRule.addAction(

new actions.SQSQueueAction(queue, { role }),

);

topicRule.addAction(new actions.SQSQueueAction(queue, { role }));

Thank you. I fixed.

Pull request has been modified.

…st.ts Co-authored-by: Adam Ruka <adamruka85@gmail.com>

…ws-cdk into aws-iot-actions-sqs

dyoshikawa · 2022-01-04T02:27:23Z

@skinny85 Thank you for your review. I fixed by your advices. Can you review one more time?

skinny85

Looks good @dyoshikawa! A few las tiny details, and we can get this merged in!

packages/@aws-cdk/aws-iot-actions/README.md

skinny85 · 2022-01-04T02:37:18Z

packages/@aws-cdk/aws-iot-actions/test/sqs/sqs-queue-action.test.ts

+  const topicRule = new iot.TopicRule(stack, 'MyTopicRule', {
+    sql: iot.IotSql.fromStringAsVer20160323("SELECT topic(2) as device_id FROM 'device/+/data'"),
+  });
+  const queue = sqs.Queue.fromQueueArn(stack, 'MyQueue', 'arn:aws:s3::123456789012:test-queue');


s3 is probably the wrong service name here 🙂.

Thanks. I fixed.

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

"arn:aws:sqs::123456789012:test-queue"

…ws-cdk into aws-iot-actions-sqs

dyoshikawa · 2022-01-04T02:46:54Z

@skinny85 Thank you so much for your reviews. I fixed all, so can you review?

skinny85

Fantastic contribution, thanks for working on this @dyoshikawa!

mergify · 2022-01-04T03:28:53Z

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2022-01-04T03:29:45Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
Commit ID: a7e8542
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Fixes aws#17699 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

dyoshikawa added 2 commits December 11, 2021 23:26

create sqs-queue-action

3b0e372

Add "aws iot actions put sqs queue" to README

daaac89

github-actions bot added the @aws-cdk/aws-iot-actions label Dec 19, 2021

github-actions bot assigned skinny85 Dec 19, 2021

dyoshikawa added 5 commits December 31, 2021 22:02

Add comments

17e97a1

Fix iot sqs queue action

30390ec

fix iot sqs queue action

f1cb8d0

Add integ.sqs-queue-action.expected.json

b453049

fix iot sqs queue action

0866ba9

dyoshikawa changed the title ~~WIP aws-iot-actions sqs~~ [WIP]feat(iot): Add Action to send messages in SQS queues #17699 Dec 31, 2021

github-actions bot added the @aws-cdk/aws-iot Related to AWS IoT label Dec 31, 2021

dyoshikawa and others added 2 commits January 1, 2022 00:20

Add iot sqs queue action to README

1efd709

Merge branch 'master' into aws-iot-actions-sqs

78e339e

dyoshikawa marked this pull request as ready for review December 31, 2021 15:21

dyoshikawa changed the title ~~[WIP]feat(iot): Add Action to send messages in SQS queues #17699~~ feat(iot): Add Action to send messages in SQS queues #17699 Dec 31, 2021

Fix @aws-cdk/aws-iot-actions/README.md

f9ce056

dyoshikawa mentioned this pull request Dec 31, 2021

(iot): TopicRule action for SQS in AWS IoT #17699

Closed

2 tasks

dyoshikawa changed the title ~~feat(iot): Add Action to send messages in SQS queues #17699~~ feat(iot): Add Action to send messages in SQS queues Jan 1, 2022

skinny85 previously requested changes Jan 4, 2022

View reviewed changes

"SqsQueueAction"

32a9816

dyoshikawa and others added 4 commits January 4, 2022 11:07

fix README

ac10a14

fix a SqsQueueAction comment

7d3f949

Update packages/@aws-cdk/aws-iot-actions/test/sqs/sqs-queue-action.te…

92ea1cb

…st.ts Co-authored-by: Adam Ruka <adamruka85@gmail.com>

fix SQS queue action test files

d96980d

dyoshikawa and others added 2 commits January 4, 2022 11:16

Merge branch 'aws-iot-actions-sqs' of https://github.com/dyoshikawa/a…

a8d794e

…ws-cdk into aws-iot-actions-sqs

Merge branch 'master' into aws-iot-actions-sqs

584dbe7

skinny85 reviewed Jan 4, 2022

View reviewed changes

dyoshikawa and others added 5 commits January 4, 2022 11:43

Update packages/@aws-cdk/aws-iot-actions/README.md

9a97aca

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iot-actions/README.md

a7e8542

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

Update packages/@aws-cdk/aws-iot-actions/README.md

9a72234

Co-authored-by: Adam Ruka <adamruka85@gmail.com>

fix sqs-queue-action.test.ts

7418241

"arn:aws:sqs::123456789012:test-queue"

Merge branch 'aws-iot-actions-sqs' of https://github.com/dyoshikawa/a…

af64341

…ws-cdk into aws-iot-actions-sqs

skinny85 changed the title ~~feat(iot): Add Action to send messages in SQS queues~~ feat(iot): Action to send messages to SQS queues Jan 4, 2022

skinny85 approved these changes Jan 4, 2022

View reviewed changes

mergify bot merged commit 37537fe into aws:master Jan 4, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(iot): Action to send messages to SQS queues #18087

feat(iot): Action to send messages to SQS queues #18087

dyoshikawa commented Dec 19, 2021 •

edited by skinny85

Loading

gitpod-io bot commented Dec 19, 2021

mergify bot commented Dec 19, 2021

skinny85 commented Dec 20, 2021

dyoshikawa commented Dec 28, 2021

dyoshikawa commented Dec 31, 2021

skinny85 left a comment

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

dyoshikawa commented Jan 4, 2022

skinny85 left a comment

skinny85 Jan 4, 2022

dyoshikawa Jan 4, 2022

dyoshikawa commented Jan 4, 2022

skinny85 left a comment

mergify bot commented Jan 4, 2022

aws-cdk-automation commented Jan 4, 2022

	export interface SQSQueueActionProps extends CommonActionProps {
	export interface SqsQueueActionProps extends CommonActionProps {

	export class SQSQueueAction implements iot.IAction {
	export class SqsQueueAction implements iot.IAction {

	test('Default sqs queue action', () => {
	test('Default SQS queue action', () => {

feat(iot): Action to send messages to SQS queues #18087

feat(iot): Action to send messages to SQS queues #18087

Conversation

dyoshikawa commented Dec 19, 2021 • edited by skinny85 Loading

gitpod-io bot commented Dec 19, 2021

mergify bot commented Dec 19, 2021

skinny85 commented Dec 20, 2021

dyoshikawa commented Dec 28, 2021

dyoshikawa commented Dec 31, 2021

skinny85 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dyoshikawa commented Jan 4, 2022

skinny85 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dyoshikawa commented Jan 4, 2022

skinny85 left a comment

Choose a reason for hiding this comment

mergify bot commented Jan 4, 2022

aws-cdk-automation commented Jan 4, 2022

AWS CodeBuild CI Report

dyoshikawa commented Dec 19, 2021 •

edited by skinny85

Loading