feat(aws-s3): support number of newer versions to retain in lifecycle policy #18225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
otaviomacedo
approved these changes
Jan 10, 2022
otaviomacedo
added
the
pr-linter/exempt-readme
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
… policy (aws#18225) The AWS Management console and CloudFormation support to set a number of noncurrent versions to be retained for S3 lifecycle transitions as described in aws#17996. This pull request introduces the property for S3 lifecycle configurations as an optional property to CDK. The maximum supported number of noncurrent versions that could be retained is 100 which is also documented for the new property. However, no additional check is inserted if the number set by the developer is actually between 0 and 100. If this check is desired, a discussion would be good on how to achieve throwing an error as I don't see a smooth solution. Resolves aws#17996. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS Management console and CloudFormation support to set a number of noncurrent versions to be retained for S3 lifecycle transitions as described in #17996.
This pull request introduces the property for S3 lifecycle configurations as an optional property to CDK.
The maximum supported number of noncurrent versions that could be retained is 100 which is also documented for the new property. However, no additional check is inserted if the number set by the developer is actually between 0 and 100. If this check is desired, a discussion would be good on how to achieve throwing an error as I don't see a smooth solution.
Resolves #17996.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license