fix(pipelines): "Maximum schema version supported" error #18404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are currently releasing both v1 and v2 streams of the CDK in parallel, with changes landing on v1 before they land on v2. By default, CDK Pipelines will use the "latest" CLI version. However, because "latest" always comes from the v2 version stream (since that has the highest number), there may be changes to the cx protocol in a v1 app that aren't supported by the v2 CLI yet. The "correct" solution to this would be one of (a) releasing v1 and v2 synchronously and making sure both have the same change set; or (b) not having a v2 CLI at all. Both of these would require significant engineering effort to resolve though. In the mean time, add the concept of a "preferred CLI version" to CDK Pipelines, set to `1` for most packages but to `2` for `aws-cdk-lib`, and have NPM install the "latest" CLI from the same version stream that the library is from. Fixes #18370.
|
|
…-cdk into huijbers/pipelines-cxapi-version
otaviomacedo
approved these changes
Jan 13, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
We are currently releasing both v1 and v2 streams of the CDK in parallel, with changes landing on v1 before they land on v2. By default, CDK Pipelines will use the "latest" CLI version. However, because "latest" always comes from the v2 version stream (since that has the highest number), there may be changes to the cx protocol in a v1 app that aren't supported by the v2 CLI yet. The "correct" solution to this would be one of (a) releasing v1 and v2 synchronously and making sure both have the same change set; or (b) not having a v2 CLI at all. Both of these would require significant engineering effort to resolve though. In the mean time, add the concept of a "preferred CLI version" to CDK Pipelines, set to `1` for most packages but to `2` for `aws-cdk-lib`, and have NPM install the "latest" CLI from the same version stream that the library is from. Fixes aws#18370. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are currently releasing both v1 and v2 streams of the CDK in
parallel, with changes landing on v1 before they land on v2. By default,
CDK Pipelines will use the "latest" CLI version.
However, because "latest" always comes from the v2 version stream (since
that has the highest number), there may be changes to the cx protocol in
a v1 app that aren't supported by the v2 CLI yet.
The "correct" solution to this would be one of (a) releasing v1 and
v2 synchronously and making sure both have the same change set; or (b)
not having a v2 CLI at all. Both of these would require significant
engineering effort to resolve though.
In the mean time, add the concept of a "preferred CLI version" to CDK
Pipelines, set to
1for most packages but to2foraws-cdk-lib,and have NPM install the "latest" CLI from the same version stream
that the library is from.
Fixes #18370.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license