fix(lambda-nodejs): logLevel property of BundlingOptions is ignored when nodeModules are defined

[flavioleggio]

In this pull request I managed to propagate the effect of the logLevel property downstream to the PackageManager class.

I had to refactor the static approach for constructing handler objects for the various package managers as we need to pass a new optional property in the fromLockFile(lockFilePath: string) static builder method.

The value for installCommand attribute in the constructor now depends on the log level and the approach varies between package managers: while npm ci supports a flexible --loglevel command option matching each of the LogLevel enum existing values, yarn install only supports a --silent option and similarly pnpm install supports a --reporter=silent which suppresses the command output except for errors and warnings. For yarn and pnpm my idea is to include the silent options whenever a log level is specified and its value is different from the default LogLevel.INFO.

I also adapted existing unit tests and added new ones taking into account the property's value. I have no experience with yarn and pnpm and I am not sure that any tests exist using bundling with yarn- and pnpm-based lambda function handlers, so I cannot guarantee that my changes work for that too.

Fixes #18383

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[corymhall]

@jogold can you take a look?

[jogold]

@jogold can you take a look?

Will do, this week or next week.

[flavioleggio]

@jogold did you have a chance to take a look at this?

[jogold]

Sorry for the late reply @flavioleggio.

This looks good.

Can you update the jsdoc in types.ts both for the LogLevel enum and the logLevel prop to reflect that this log level doesn't only apply to esbuild now?

[flavioleggio]

Hi @jogold

Sorry for the late reply @flavioleggio.

No worries!

Can you update the jsdoc in types.ts both for the LogLevel enum and the logLevel prop to reflect that this log level doesn't only apply to esbuild now?

Done

[jogold]

@corymhall LGTM

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: a53dafd
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).