fix(cli): cdk watch constantly prints 'messages suppressed'
#18486
Conversation
… non-empty response Currently if `filterLogEvents` returns a nextToken then we print `(...messages suppressed...)`. According to the docs "This operation can return empty results while there are more log events available through the token.". This fix adds a condition to only print out the suppression message if `filterLogEvents` returns non-empty results. Also fixes the spelling of `suppressed`. fixes #18451
|
|
rix0rrr
changed the title
cdk watch constantly prints 'messages suppressed'
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| events.push({ | ||
| message: '(...messages supressed...)', | ||
| message: '(...messages suppressed...)', |
There was a problem hiding this comment.
Can we change this to something like:
| message: '(...messages suppressed...)', | |
| message: '>>> `watch` shows only the first 100 log messages - the rest have been truncated...', |
Feel free to word-smith the exact wording, of course.
There was a problem hiding this comment.
@skinny85 updated.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
) Currently if `filterLogEvents` returns a nextToken then we print `(...messages suppressed...)`. According to the docs "This operation can return empty results while there are more log events available through the token.". This fix adds a condition to only print out the suppression message if `filterLogEvents` returns non-empty results. Also updates the message to be more descriptive. fixes aws#18451 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Currently if
filterLogEventsreturns a nextToken then we print(...messages suppressed...). According to the docs "This operationcan return empty results while there are more log events available
through the token.".
This fix adds a condition to only print out the suppression message if
filterLogEventsreturns non-empty results.Also updates the message to be more descriptive.
fixes #18451
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license