-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(assertions): stringLikeRegexp()
matcher
#18491
Conversation
Can you compare with this implementation and see what's different? Niranjan reimplemented it for Pipelines, I don't know if he changed anything: aws-cdk/packages/@aws-cdk/pipelines/test/testhelpers/matchers.ts Lines 20 to 43 in 604564c
|
stringLike()
matcherstringLike()
matcher
stringLike()
matcherstringLikeRegexp()
matcher
Provisional approval after small changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve as well :). Thanks for this!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The logic was partly copied from the function with the same name from `assert-internal`, but the implementation was changed to use [minimatch](https://github.com/isaacs/minimatch). This way, we can have a well-known and stable contract for the matcher. Closes aws#18051. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The logic was partly copied from the function with the same name from
assert-internal
, but the implementation was changed to use minimatch. This way, we can have a well-known and stable contract for the matcher.Closes #18051.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license