Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(custom-resources): physical resource id must be determined before isComplete #18630

Merged
merged 3 commits into from
Feb 26, 2022
Merged

fix(custom-resources): physical resource id must be determined before isComplete #18630

merged 3 commits into from
Feb 26, 2022

Conversation

pflorek
Copy link
Contributor

@pflorek pflorek commented Jan 24, 2022

For some resource on event can only generate an intermediary physical resource id. On isComplete the actual physical resource id can be retrieved from the created resource. Therefor it's useful to override the temporary one.

Fixes #18670


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 24, 2022

@github-actions github-actions bot added the @aws-cdk/custom-resources Related to AWS CDK Custom Resources label Jan 24, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Set the actual physical resource id of an asynchronous operation, when the waiter is finished with isComplete: true

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…complete
@rix0rrr rix0rrr changed the title fix(custom-resources): set actual physical resource id on isComplete fix(custom-resources): allow returning physical resource id from isComplete Feb 26, 2022
@rix0rrr rix0rrr changed the title fix(custom-resources): allow returning physical resource id from isComplete fix(custom-resources): physical resource id must be determined before isComplete Feb 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…complete
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 831f97f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c190367 into aws:master Feb 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@pflorek
Copy link
Contributor Author

pflorek commented Mar 2, 2022

@rix0rrr Thank you!!! 😍

@pflorek pflorek deleted the fix/set-actual-physical-resource-id-on-is-complete branch March 2, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources
Projects
None yet
3 participants