Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: construct paths are not printed for nested stacks in CLI output #18725

Merged
merged 4 commits into from
Feb 26, 2022
Merged

fix: construct paths are not printed for nested stacks in CLI output #18725

merged 4 commits into from
Feb 26, 2022

Conversation

visadb
Copy link
Contributor

@visadb visadb commented Jan 28, 2022

This fixes issue #18724

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 28, 2022

@mergify
Copy link
Contributor

mergify bot commented Jan 28, 2022

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Jan 28, 2022
@visadb visadb changed the title Nested stacks: hierarchical names in CLI output fix: print hierarchical names for nested stacks in CLI output Jan 28, 2022
@visadb visadb force-pushed the hierarchical-nested-stack-names-in-cdk-output branch from fa6089d to f84275e Compare January 28, 2022 17:01
@visadb visadb mentioned this pull request Jan 28, 2022
Closed
rix0rrr
rix0rrr previously requested changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hear you. I'm pretty sure that displayName should have put in some effort to show the path names already if they were present though. Can you confirm/disconfirm that?

visadb added 2 commits February 1, 2022 00:04
@visadb
Nested stacks: hierarchical names in CLI output
613779b 
This fixes issue aws#18724
@visadb
Revert "Nested stacks: hierarchical names in CLI output"
bf6ed23 
This reverts commit b9e3db5af8937951578a2e97ba29fc8654a54c7e.
@visadb visadb force-pushed the hierarchical-nested-stack-names-in-cdk-output branch from f84275e to 7828f20 Compare January 31, 2022 22:04
@mergify mergify bot dismissed rix0rrr’s stale review January 31, 2022 22:05

Pull request has been modified.

@visadb visadb force-pushed the hierarchical-nested-stack-names-in-cdk-output branch from 7828f20 to c6b1dbf Compare January 31, 2022 22:08
@visadb
Copy link
Contributor Author

visadb commented Jan 31, 2022

@rix0rrr Absolutely, I agree! Being unfamiliar with the aws-cdk codebase, that quick-and-dirty solution seemed reasonable. 😅

I implemented your suggestion of utilizing hierarchichalId in displayName.

@visadb visadb requested a review from rix0rrr January 31, 2022 22:24
@visadb visadb force-pushed the hierarchical-nested-stack-names-in-cdk-output branch from c6b1dbf to eaaa093 Compare January 31, 2022 22:36
@visadb visadb force-pushed the hierarchical-nested-stack-names-in-cdk-output branch from eaaa093 to 2fbbe9e Compare January 31, 2022 22:38
@rix0rrr rix0rrr changed the title fix: print hierarchical names for nested stacks in CLI output fix: construct paths are not printed for nested stacks in CLI output Feb 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b3f7fa5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b0e0155 into aws:master Feb 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@visadb @aws-cdk-automation @rix0rrr