-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-apigateway): add ability to include authorizer context in apigw sfn integration #18892
Conversation
Is there an easy way to generate the expected string from the CFN template that the test is failing on? |
Pull request has been modified.
@rogerchi I updated the tests for you. |
@@ -193,6 +193,7 @@ new apigateway.StepFunctionsRestApi(this, 'StepFunctionsRestApi', { | |||
headers: true, | |||
path: false, | |||
querystring: false, | |||
authorizer: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part was actually not implemented. Please take a look at the build failure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad -- I added it to the Integration but not the RestApi
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…igw sfn integration (aws#18892) Implements aws#18891 This PR adds the ability to include custom authorizer context in the Step Functions API Gateway integration. This is useful if the custom authorizer sets custom context values, which can then be used downstream in the step function. This adds a `authorizer: { ... }` key to the state input. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Implements #18891
This PR adds the ability to include custom authorizer context in the Step Functions API Gateway integration. This is useful if the custom authorizer sets custom context values, which can then be used downstream in the step function. This adds a
authorizer: { ... }
key to the state input.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license