Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@aws-cdk/aws-appsync): support for GraphQL documentation #18907

Closed
2 tasks
fab-mindflow opened this issue Feb 10, 2022 · 2 comments
Closed
2 tasks

(@aws-cdk/aws-appsync): support for GraphQL documentation #18907

fab-mindflow opened this issue Feb 10, 2022 · 2 comments
Labels
@aws-cdk/aws-appsync Related to AWS AppSync closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. feature-request A feature should be added or improved. p2

Comments

@fab-mindflow
Copy link

Description

It looks like there is no support in code first approach to add documentation (block strings) to generated GraphQL schemas.

Use Case

Generated GraphQL would contain documentation on fields and types.
Tools can then use introspection queries to display documentation from GraphQL schemas generated by @aws-cdk/aws-appsync (we have the use case for our platform).

Proposed Solution

Add an attribute to FieldOptions, IntermediateTypeOptions and more to allow documenting types and fields.

const demo = new appsync.ObjectType('Demo', {
  description: "THIS IS SOME DOCUMENTATION",
  interfaceTypes: [ node ],
  definition: {
    version: appsync.GraphqlType.string({ isRequired: true }),
  },
});

That would result in GraphQL schema:

"""THIS IS SOME DOCUMENTATION"""
type demo {
  id: String!
  version: String!
}

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@fab-mindflow fab-mindflow added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 10, 2022
@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Feb 10, 2022
@otaviomacedo otaviomacedo added p2 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2022
@otaviomacedo otaviomacedo removed their assignment Feb 23, 2022
@otaviomacedo
Copy link
Contributor

It seems that AppSync doesn't support this feature yet: aws/aws-appsync-community#38.

@github-actions
Copy link

This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Feb 25, 2023
@github-actions github-actions bot closed this as completed Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

2 participants