Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(triggers): not published as part of v2 #19168

Merged
merged 4 commits into from
Feb 26, 2022
Merged

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Feb 26, 2022

Config that explicitly excluded the package from the v2 build
had slipped in.

Fixes #19164.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Config that explicitly excluded the package from the v2 build
had slipped in.

Fixes #19164.
@rix0rrr rix0rrr requested a review from a team February 26, 2022 01:37
@rix0rrr rix0rrr self-assigned this Feb 26, 2022
@gitpod-io
Copy link

gitpod-io bot commented Feb 26, 2022

@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Feb 26, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 26, 2022
@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Feb 26, 2022
packages/monocdk/package.json Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 743cf3d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8f727d1 into master Feb 26, 2022
@mergify mergify bot deleted the huijbers/triggers-v2 branch February 26, 2022 04:06
@mergify
Copy link
Contributor

mergify bot commented Feb 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify bot pushed a commit that referenced this pull request Feb 26, 2022
Reference: #19168

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@@ -106,9 +106,6 @@
"AWSLINT_BASE_CONSTRUCT": true
}
},
"ubergen": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oouch - this came from the CDK module template... Probably worth fixing there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package contribution/core This is a PR that came from AWS. pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triggers: Module not included in 2.14 release
7 participants