Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): long connection timeout slows the CLI down #19187

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

otaviomacedo
Copy link
Contributor

@otaviomacedo otaviomacedo commented Feb 28, 2022

Setting a timeout of 3 seconds for both the connection and the response, making the CLI give up fast in case of network issues or high latency.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 28, 2022

@otaviomacedo otaviomacedo requested a review from a team February 28, 2022 17:03
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Feb 28, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 2ead047
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6595d04 into master Feb 28, 2022
@mergify mergify bot deleted the otaviom/notices-timeout branch February 28, 2022 18:30
@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants