Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudwatch): Add CustomWidget #19327

Merged
merged 24 commits into from
May 2, 2022

Conversation

markussiebert
Copy link
Contributor

@markussiebert markussiebert commented Mar 10, 2022

This PR introcudes the CustomWidget for Cloudwatch Dashboards

fixes: #17579

based on the work of @dannyber

If you wonder, why only a string typed option was used instead of an lambda.IFunction, the reason is, that this would introduce a circular dependency between lambda -> cloudwatch -> lambda and leads to build errors.

Creating a new package for this tiny feature to work around the circular dependency would be too much of a good thing. Apart from that it could be unintuitive to find the custom widget in a package 'aws-cloudwatch-pattarns' if all other widgets come from 'aws-cloudwatch'.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 10, 2022

@markussiebert markussiebert marked this pull request as draft March 10, 2022 11:07
@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Mar 10, 2022
@markussiebert markussiebert changed the base branch from master to huijbers/reorg-cli March 13, 2022 19:42
@markussiebert markussiebert changed the base branch from huijbers/reorg-cli to master March 13, 2022 19:43
@markussiebert markussiebert marked this pull request as ready for review March 13, 2022 19:45
@markussiebert markussiebert changed the title feat(lcloudwatch): Add CustomWidget feat(cloudwatch): Add CustomWidget Mar 14, 2022
@markussiebert markussiebert reopened this Mar 14, 2022
@knightjoel
Copy link
Contributor

Hi @markussiebert, following this PR with much interest. Have you requested a review from @madeline-k yet? You should be able to click Madeline's avatar just to the right of your original comment on the PR to request a review.

@markussiebert
Copy link
Contributor Author

Hi @knightjoel - I can't - something I am struggling with. I don't know where to click. But I've already written with @madeline-k on cdk.dev and she promised to review both of my CW PRs. I think she is busy at the moment?!

Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, I am still looking for documentation of the cloudwatch API for all the properties of custom widgets.

packages/@aws-cdk/aws-cloudwatch/README.md Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/lib/graph.ts Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/lib/graph.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-cloudwatch/lib/graph.ts Show resolved Hide resolved
Co-authored-by: Madeline Kusters <80541297+madeline-k@users.noreply.github.com>
@mergify mergify bot dismissed madeline-k’s stale review March 24, 2022 08:47

Pull request has been modified.

markussiebert and others added 3 commits March 26, 2022 16:38
@knightjoel
Copy link
Contributor

Hi @markussiebert, still following with much interest. Is this ready for another review? Have all of Madeline's comments been addressed?

@markussiebert
Copy link
Contributor Author

Hi @markussiebert, still following with much interest. Is this ready for another review? Have all of Madeline's comments been addressed?

I hope so :-) I pinged her via cdk.dev - maybe she will review this again - the review request here is open since some time

Copy link
Contributor

@madeline-k madeline-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @markussiebert! 😄

@mergify
Copy link
Contributor

mergify bot commented May 2, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 6f6cd5b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 489340e into aws:master May 2, 2022
@mergify
Copy link
Contributor

mergify bot commented May 2, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

wphilipw pushed a commit to wphilipw/aws-cdk that referenced this pull request May 23, 2022
This PR introcudes the CustomWidget for Cloudwatch Dashboards

fixes: aws#17579

based on the work of @dannyber

If you wonder, why only a string typed option was used instead of an lambda.IFunction, the reason is, that this would introduce a circular dependency between lambda -> cloudwatch -> lambda and leads to build errors.

Creating a new package for this tiny feature to work around the circular dependency would be too much of a good thing. Apart from that it could be unintuitive to find the custom widget in a package 'aws-cloudwatch-pattarns' if all other widgets come from 'aws-cloudwatch'.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cloudwatch): support Custom Widgets
4 participants