Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integ-runner): disable-update-workflow default is 'false' instead of false #20073

Merged
merged 3 commits into from
Apr 27, 2022
Merged

fix(integ-runner): disable-update-workflow default is 'false' instead of false #20073

merged 3 commits into from
Apr 27, 2022

Conversation

corymhall
Copy link
Contributor

disable-update-workflow is a boolean, but the default value was a
string 'false'. Update the default to be a boolean false value.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

… of false

`disable-update-workflow` is a boolean, but the default value was a
string 'false'. Update the default to be a boolean `false` value.
@gitpod-io
Copy link

gitpod-io bot commented Apr 25, 2022

@corymhall corymhall requested a review from otaviomacedo April 25, 2022 18:57
@github-actions github-actions bot added the p2 label Apr 25, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team April 25, 2022 18:57
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Apr 25, 2022
@corymhall corymhall added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 25, 2022
@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-test The PR linter will not require test changes label Apr 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: c50ce27
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9f7aa65 into aws:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants