Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-python): handler path is incorrectly generated when using PythonFunction #20083

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

sarisia
Copy link
Contributor

@sarisia sarisia commented Apr 26, 2022

When using PythonFunction, current implementation generates handler value incorrectly.

Code

new PythonFunction(stack, 'handler', {
    entry: 'test/lambda-handler-sub-nested',
    index: 'inner/inner2/custom_index.py',
    handler: 'custom_handler',
    runtime: Runtime.PYTHON_3_8,
});

Expected

Handler: inner.inner2.custom_index.custom_handler

Current Behaviour

Handler: inner.inner2/custom_index.custom_handler

This PR fix the issue by modifying string replace pattern.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 26, 2022

@github-actions github-actions bot added the p2 label Apr 26, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2022 01:38
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this change have an issue associated with it? If so, please add it to the description.

@sarisia
Copy link
Contributor Author

sarisia commented Apr 26, 2022

Does this change have an issue associated with it? If so, please add it to the description.

We don’t have an open issue.

@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(aws-lambda-python): fix incorrectly generated handler when using PythonFunction fix(lambda-python): handler path is incorrectly generated when using PythonFunction Apr 26, 2022
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sarisia
Copy link
Contributor Author

sarisia commented Apr 26, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 6787376 into aws:master Apr 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 332cc7e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants