Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-eks): allow the use of graviton3 processors #20543

Merged
merged 8 commits into from
Jun 20, 2022

Conversation

gergnz
Copy link
Contributor

@gergnz gergnz commented May 30, 2022

feat: allow the use of graviton3, 7th generation processors

fixes: #20482


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 30, 2022

@github-actions github-actions bot added the p2 label May 30, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team May 30, 2022 11:10
@gergnz gergnz changed the base branch from v1-main to main June 1, 2022 21:50
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Looks like we just need an integration test for this change. As @corymhall mentioned in #20498, you can just update a current one to include the new instance type.

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Looks like we just need an integration test for this change. As @corymhall mentioned in #20498, you can just update a current one to include the new instance type.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review June 14, 2022 09:05

Pull request has been modified.

@gergnz
Copy link
Contributor Author

gergnz commented Jun 14, 2022

Thank you for your contribution. Looks like we just need an integration test for this change. As @corymhall mentioned in #20498, you can just update a current one to include the new instance type.

Added integration test.

@TheRealAmazonKendra
Copy link
Contributor

Thank you for your contribution. Looks like we just need an integration test for this change. As @corymhall mentioned in #20498, you can just update a current one to include the new instance type.

Added integration test.

Thank you for getting that added. We just need the build working and then I'm happy to approve this. Can you please take a look at the failure?

@gergnz
Copy link
Contributor Author

gergnz commented Jun 16, 2022

@TheRealAmazonKendra good to go please.

@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 54ff451
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 98b52de into aws:main Jun 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa pushed a commit to daschaa/aws-cdk that referenced this pull request Jul 9, 2022
feat: allow the use of graviton3, 7th generation processors

fixes: aws#20482

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_cdk.aws_ec2.InstanceClass: Support COMPUTE7_GRAVITON3
3 participants