Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip uploading assets when there is no diff #20716

Closed
2 tasks
rittneje opened this issue Jun 13, 2022 · 6 comments
Closed
2 tasks

skip uploading assets when there is no diff #20716

rittneje opened this issue Jun 13, 2022 · 6 comments
Assignees
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@rittneje
Copy link

Describe the feature

cdk deploy should detect whether this is actually a diff for the stack in question before uploading the assets for it. If there isn't then it should skip uploading them.

Use Case

We follow IaC, which means that we always run cdk deploy for all stacks on every build. Consequently, often times there are no changes at all to deploy for a certain stack (or several stacks). But we've noticed that cdk does not detect this until after it uploads the assets to the staging bucket, which wastes time.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.21.1 (build a6ee543)

Environment details (OS name and version, etc.)

Alpine 3.15, Python 3.9.12

@rittneje rittneje added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 13, 2022
@github-actions github-actions bot added the @aws-cdk/assets Related to the @aws-cdk/assets package label Jun 13, 2022
@peterwoodworth peterwoodworth removed the needs-triage This issue or PR still needs to be triaged. label Jun 13, 2022
@peterwoodworth peterwoodworth added the duplicate This issue is a duplicate. label Jun 13, 2022
@peterwoodworth
Copy link
Contributor

Thanks for the request @rittneje,

This is being tracked here #18045. There's a proof of concept up for the feature for anyone to take over 🙂

@peterwoodworth peterwoodworth closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@rittneje
Copy link
Author

@peterwoodworth #18045 seems completely unrelated to this. That is about cdk watch skipping synthesis. This is about cdk deploy deferring uploading assets until after it has determined there is a diff. Please re-open this issue.

@peterwoodworth
Copy link
Contributor

You're right - I'm not sure what I read initially

@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 25, 2023

Has been implemented already

@rix0rrr rix0rrr closed this as completed Sep 25, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

5 participants