fix(integ-tests): assertions stack not deployed on v2 #21646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is no longer valid in CDK v2 to specify stacks to deploy by the stack name. This PR updates the logic to use the stack id. I've also re-ran the integration tests that use assertions to verify that the assertion stacks are now deployed. fixes #21639
|
|
github-actions
bot
added
bug
mrgrain
approved these changes
Aug 18, 2022
|
@Mergifyio update |
✅ Branch has been successfully updated |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
1 similar comment
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
In #21646 we updated the `assertionStack` value to be the `node.id` of the assertion stack since that is what the CDK CLI requires to deploy the stack. The change in #21646 fixed that bug, but it introduced a new one where the assertion results are no longer read and reported on by the integ-runner. The integ-runner reads the results of the assertions from the stack outputs which are written to a file (with `cdk deploy --output `assertion-results.json`). The outputs use the stack _name_ not the _node.id_. As a result, the integ-runner was looking for outputs for an invalid stack name. This PR fixes that by: - Adding `assertionStackName` property to the `integ.json` manifest - Updates the integ-runner to use the `assertionsStackName` to lookup the assertion results. - Add reporting on assertion results (previously only reported failures). - Updates all integ snapshots which currently use assertions. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
It is no longer valid in CDK v2 to specify stacks to deploy by the stack name. This PR updates the logic to use the stack id. I've also re-ran the integration tests that use assertions to verify that the assertion stacks are now deployed. fixes aws#21639 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
In aws#21646 we updated the `assertionStack` value to be the `node.id` of the assertion stack since that is what the CDK CLI requires to deploy the stack. The change in aws#21646 fixed that bug, but it introduced a new one where the assertion results are no longer read and reported on by the integ-runner. The integ-runner reads the results of the assertions from the stack outputs which are written to a file (with `cdk deploy --output `assertion-results.json`). The outputs use the stack _name_ not the _node.id_. As a result, the integ-runner was looking for outputs for an invalid stack name. This PR fixes that by: - Adding `assertionStackName` property to the `integ.json` manifest - Updates the integ-runner to use the `assertionsStackName` to lookup the assertion results. - Add reporting on assertion results (previously only reported failures). - Updates all integ snapshots which currently use assertions. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer valid in CDK v2 to specify stacks to deploy by the stack
name. This PR updates the logic to use the stack id.
I've also re-ran the integration tests that use assertions to verify
that the assertion stacks are now deployed.
fixes #21639
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license