Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-cloudwatch): add support for sparkline graphs in SingleValueWidget #21684

Merged
merged 4 commits into from
Aug 22, 2022
Merged

feat(aws-cloudwatch): add support for sparkline graphs in SingleValueWidget #21684

merged 4 commits into from
Aug 22, 2022

Conversation

ackjewtn
Copy link
Contributor

Adds configuration option for enabling sparkline in SingleValueWidget.

Fixes #21683

@gitpod-io
Copy link

gitpod-io bot commented Aug 19, 2022

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 labels Aug 19, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team August 19, 2022 12:47
@TheRealAmazonKendra TheRealAmazonKendra changed the title feat(aws-cloudwatch): Add support for sparkline graphs in SingleValueWidget feat(aws-cloudwatch): add support for sparkline graphs in SingleValueWidget Aug 22, 2022
TheRealAmazonKendra
TheRealAmazonKendra previously requested changes Aug 22, 2022
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This looks good, we'll just need a README update and an integ test for this change.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review August 22, 2022 09:30

Pull request has been modified.

@ackjewtn
Copy link
Contributor Author

Thanks for the feedback @TheRealAmazonKendra - let me know if anything more is needed now

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cf94911
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cf5d115 into aws:main Aug 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

josephedward pushed a commit to josephedward/aws-cdk that referenced this pull request Aug 30, 2022
@ackjewtn @josephedward
feat(aws-cloudwatch): add support for sparkline graphs in SingleValue…
820ebd6 
…Widget (aws#21684)

Adds configuration option for enabling sparkline in SingleValueWidget.



Fixes aws#21683
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall corymhall approved these changes

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra left review comments

Assignees
No one assigned
Labels
feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-cloudwatch): (sparkline for SingleValueWidget)
4 participants
@ackjewtn @aws-cdk-automation @corymhall @TheRealAmazonKendra