Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-cdk): (CDK generates ECR repositories that don't adhere to Security Hub compliance packs) #21869

Closed
meghannoelle opened this issue Sep 1, 2022 · 2 comments
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry bug This issue is a bug. cause/not-a-bug Not a bug (might still be a documentation issue, might still need work)

Comments

@meghannoelle
Copy link

Describe the bug

CDK provisioned ECR repositories cause the following finding in Security Hub:
ECR.2 ECR private repositories should have tag immutability configured
(https://docs.aws.amazon.com/securityhub/latest/userguide/securityhub-standards-fsbp-controls.html#ecr-2-remediation)

Expected Behavior

I expected CDK-provisioned ECR repositories to have tag immutability configured by default.

Current Behavior

CDK-provisioned ECR repositories don't have tag immutability configured and are breaching Security Hub's AWS foundational security best practices.

Reproduction Steps

Deploy an ECR repo and note the new security finding in Security Hub.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.35.0 (build 5c23578)

Framework Version

No response

Node.js Version

v14.18.1

OS

MacOS

Language

Typescript

Language Version

No response

Other information

No response

@meghannoelle meghannoelle added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 1, 2022
@github-actions github-actions bot added the @aws-cdk/aws-ecr Related to Amazon Elastic Container Registry label Sep 1, 2022
@peterwoodworth peterwoodworth added cause/not-a-bug Not a bug (might still be a documentation issue, might still need work) and removed needs-triage This issue or PR still needs to be triaged. labels Sep 1, 2022
@peterwoodworth
Copy link
Contributor

We don't necessarily support Security Hub guidelines by default. Here's some discussion around potential way we may be able to accomplish this in the future easily, but for now you can configure this with imageTagMutability prop

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecr Related to Amazon Elastic Container Registry bug This issue is a bug. cause/not-a-bug Not a bug (might still be a documentation issue, might still need work)
Projects
None yet
Development

No branches or pull requests

3 participants