feat(neptune): enable cloudwatch logs exports #22004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduce LogType and CloudwatchLogsExports for use in DatabaseClusterProps - introduce cloudwatchLogsExports prop to configure which log types should be exported to CloudWatch Logs and optionally set log retention - update tests and integ tests - update README related to aws#20248 closes aws#15888
|
|
github-actions
bot
added
effort/medium
2 tasks
corymhall
previously requested changes
Sep 13, 2022
| const clusterParameterGroup = new neptune.ClusterParameterGroup(this, 'ClusterParams', { | ||
| description: 'Cluster parameter group', | ||
| parameters: { | ||
| neptune_enable_audit_log: '1' |
There was a problem hiding this comment.
It would be cool if we could somehow do this automatically, but it doesn't look like we have that capability in these constructs currently. I'll consider it out of scope, but just wanted to leave a note.
There was a problem hiding this comment.
Absolutely, it'd be gr8 if that's handled by default. But to achieve that in a nice fashion, I think
- Maybe the cluster needs to create default cluster and instance parameter groups
- Expose methods to allow setting parameters on those groups - while also refactoring parameter groups to support exposing what parameters are there and adding/overriding the existing ones
All in all, maybe an idea for a separate PR
mergify
bot
dismissed
corymhall’s stale review
Pull request has been modified.
|
@corymhall with the comments addressed, anything else u think should be tackled before moving forwards with this PR? |
|
Ping! @corymhall :) |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
arewa
pushed a commit
to arewa/aws-cdk
that referenced
this pull request
Oct 8, 2022
- introduce LogType and CloudwatchLogsExports for use in DatabaseClusterProps - introduce cloudwatchLogsExports prop to configure which log types should be exported to CloudWatch Logs and optionally set log retention - update tests and integ tests - update README related to aws#20248 closes aws#15888 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Dec 1, 2022
- introduce LogType and CloudwatchLogsExports for use in DatabaseClusterProps - introduce cloudwatchLogsExports prop to configure which log types should be exported to CloudWatch Logs and optionally set log retention - update tests and integ tests - update README related to aws#20248 closes aws#15888 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #20248
closes #15888
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license