Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodePipeline: artifact names should be restricted to 100 characters #2230

Closed
rix0rrr opened this issue Apr 10, 2019 · 2 comments · Fixed by #2338
Closed

CodePipeline: artifact names should be restricted to 100 characters #2230

rix0rrr opened this issue Apr 10, 2019 · 2 comments · Fixed by #2338
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 10, 2019

Right now it's very easy for the autogenerated artifact names to become humongously long:

Artifact_delivlibtesthuijbersCodeCommitPipelineGenerateTwoArtifactsActionGenerateTwoArtifacts4EDEFC2E

This is 101 characters, the limit is 100.

@rix0rrr rix0rrr added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Apr 10, 2019
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Apr 10, 2019

I don't think these should contain the node's uniqueid. This is wayy overkill. How about:

${stage}-${action}-Artifact

?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Apr 10, 2019

The rules between CodePipeline and CodeBuild seem inconsistent. CodeBuild says this:

Error calling startBuild: Invalid input: identifier must contain only alphanumeric characters and underscores and be less than 128 characters in length. (Service: AWSCodeBuild; Status Code: 400; Error Code: InvalidInputException; Request ID: 61dfcc4d-5bac-11e9-a3f2-999aa7277d39)

So CodePipeline will accept the dashes, but CodeBuild won't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant