Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(integ-tests): add ability to wait for assertions to pass #22335

Merged
merged 8 commits into from
Oct 12, 2022
Merged

feat(integ-tests): add ability to wait for assertions to pass #22335

merged 8 commits into from
Oct 12, 2022

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Oct 3, 2022 •
edited
Loading

This PR adds a waitForAssertions method that allows you to wait until an assertion passes. In order to accomplish this I've copied from the asynchronous providers implementation in the @aws-cdk/custom-resources module.

I've updated 3 integration tests to use this functionality to demonstrate the possible use cases.

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@corymhall
feat(integ-tests): add ability to wait for assertion results to pass
9ec89ea 
This PR adds a `wait` method that allows you to wait until an assertion
passes. In order to accomplish this I've copied from the [asynchronous
providers](https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.custom_resources-readme.html#asynchronous-providers-iscomplete)
implementation in the `@aws-cdk/custom-resources` module.

I've updated 3 integration tests to use this functionality to
demonstrate the possible use cases.
@gitpod-io
Copy link

gitpod-io bot commented Oct 3, 2022

@github-actions github-actions bot added the p2 label Oct 3, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 3, 2022 19:27
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 3, 2022
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 3, 2022 19:29

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 3, 2022 19:30

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 4, 2022 12:49

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 4, 2022 14:22

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 4, 2022 14:23

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 4, 2022 15:01

Pull Request updated. Dissmissing previous PRLinter Review.

aws-cdk-automation
aws-cdk-automation previously requested changes Oct 4, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Pull Request Linter fails with the following errors:

❌ Features must contain a change to a README file.

PRs must pass status checks before we can provide a meaningful review.

@corymhall corymhall added the pr-linter/exempt-readme The PR linter will not require README changes label Oct 4, 2022
@corymhall
Copy link
Contributor Author

Added exempt-readme because I did update the readme...

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 4, 2022 18:12

Pull Request updated. Dissmissing previous PRLinter Review.

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 4, 2022

update

✅ Branch has been successfully updated

@TheRealAmazonKendra
Copy link
Contributor

First of all, shut up PR Linter. Secondly, I'm so hype about this.

@Naumel Naumel added the pr/do-not-merge This PR should not be merged at this time. label Oct 12, 2022
Naumel
Naumel approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@Naumel Naumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments added, nothing spotted that would act as a blocker.

packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-s3-deploy.ts
input: sourceOutput,
bucket: deployBucket,
accessControl: s3.BucketAccessControl.PUBLIC_READ,
accessControl: s3.BucketAccessControl.PRIVATE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

packages/@aws-cdk/integ-tests/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/integ-tests/lib/assertions/waiter-state-machine.ts Show resolved Hide resolved
@corymhall corymhall removed the pr/do-not-merge This PR should not be merged at this time. label Oct 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 700f9c4 into aws:main Oct 12, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: f71ab86
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naumel Naumel Naumel approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corymhall @TheRealAmazonKendra @aws-cdk-automation @Naumel