fix(custom-resources): provider can fail if S3 has brown-outs #22362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Custom Resource Provider will write a response object back to S3, but if S3 is having connection trouble, the calls will not be retried and fail. Add a simple retry loop around it.
|
|
rix0rrr
changed the title
aws-cdk-automation
previously requested changes
Oct 5, 2022
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
rix0rrr
changed the title
Naumel
reviewed
Oct 7, 2022
Comment on lines
+281
to
+291
| if (typeof (parsed.resourcesVpcConfig?.endpointPrivateAccess) === 'string') { | ||
| parsed.resourcesVpcConfig.endpointPrivateAccess = parsed.resourcesVpcConfig.endpointPrivateAccess === 'true'; | ||
| } | ||
|
|
||
| if (typeof (parsed.resourcesVpcConfig?.endpointPublicAccess) === 'string') { | ||
| parsed.resourcesVpcConfig.endpointPublicAccess = parsed.resourcesVpcConfig.endpointPublicAccess === 'true'; | ||
| } | ||
|
|
||
| if (typeof (parsed.logging?.clusterLogging[0].enabled) === 'string') { | ||
| parsed.logging.clusterLogging[0].enabled = parsed.logging.clusterLogging[0].enabled === 'true'; | ||
| } |
There was a problem hiding this comment.
[nit] can it be 3 lines calling the same method that's doing the check and assignation?
Looks same-y
There was a problem hiding this comment.
Oh, it's part of a snapshot, nevermind!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
arewa
pushed a commit
to arewa/aws-cdk
that referenced
this pull request
Oct 8, 2022
) The Custom Resource Provider will write a response object back to S3, but if S3 is having connection trouble, the calls will not be retried and fail. Add a simple retry loop around it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Dec 1, 2022
) The Custom Resource Provider will write a response object back to S3, but if S3 is having connection trouble, the calls will not be retried and fail. Add a simple retry loop around it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Custom Resource Provider will write a response object back to S3, but if S3 is having connection trouble, the calls will not be retried and fail.
Add a simple retry loop around it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license