Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssm): StringParameter.fromSecureStringParameterAttributes not working without version #22618

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Oct 24, 2022

It is possible to omit the version of an SSM SecureString parameter.

When omitted, the reference generated by CDK results in a ValidationError when applying the changes.

e.g.

Error [ValidationError]: Incorrect format is used in the following SSM reference: [{{resolve:ssm-secure:/some/parameter:}}]

Related to #18729
Replaces #22311


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 24, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team October 24, 2022 09:25
@github-actions github-actions bot added the p2 label Oct 24, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 24, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@mrgrain mrgrain force-pushed the mrgrain/fix/ssm-secure-no-version branch from 2f6f69c to 9c075da Compare October 24, 2022 12:43
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 24, 2022 12:45

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mrgrain
Copy link
Contributor Author

mrgrain commented Oct 24, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 24, 2022

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/auto-approve.yml without workflows permission
err-code: 45FDB

@mrgrain mrgrain marked this pull request as ready for review October 24, 2022 13:52
dglsparsons and others added 3 commits October 24, 2022 15:01
…orking without version

It is possible to omit the `version` of an SSM SecureString parameter.

When omitted, the reference generated by CDK results in a
ValidationError when applying the changes.

e.g.

```
Error [ValidationError]: Incorrect format is used in the following SSM reference: [{{resolve:ssm-secure:/some/parameter:}}]
```
@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@TheRealAmazonKendra
Copy link
Contributor

TBH I just did that to see if it would work after not working before.

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

update

✅ Branch has been successfully updated

@mrgrain
Copy link
Contributor Author

mrgrain commented Oct 25, 2022

TBH I just did that to see if it would work after not working before.

Make sense. 👍

I had manually rebased with the changes to the workflow file after the error. This might not be obvious from the log.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7672dfc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b33b9b0 into aws:main Oct 25, 2022
@mrgrain mrgrain deleted the mrgrain/fix/ssm-secure-no-version branch July 26, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants