-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssm): StringParameter.fromSecureStringParameterAttributes
not working without version
#22618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
2f6f69c
to
9c075da
Compare
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
@Mergifyio update |
❌ Base branch update has failedrefusing to allow a GitHub App to create or update workflow |
…orking without version It is possible to omit the `version` of an SSM SecureString parameter. When omitted, the reference generated by CDK results in a ValidationError when applying the changes. e.g. ``` Error [ValidationError]: Incorrect format is used in the following SSM reference: [{{resolve:ssm-secure:/some/parameter:}}] ```
266767d
to
1fab9e8
Compare
@Mergifyio update |
TBH I just did that to see if it would work after not working before. |
✅ Branch has been successfully updated |
Make sense. 👍 I had manually rebased with the changes to the workflow file after the error. This might not be obvious from the log. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
It is possible to omit the
version
of an SSM SecureString parameter.When omitted, the reference generated by CDK results in a ValidationError when applying the changes.
e.g.
Related to #18729
Replaces #22311
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license