Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines implementation: Attributes #2271

Closed
7 tasks
eladb opened this issue Apr 15, 2019 · 1 comment
Closed
7 tasks

Guidelines implementation: Attributes #2271

eladb opened this issue Apr 15, 2019 · 1 comment
Labels
effort/small Small work item – less than a day of effort package/awscl Cross-cutting issues related to the AWS Construct Library

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019

  • Implement and apply rule awslint:attribute-coverage: AWS resource construct interface should expose all CFN resource attributes
  • Implement and apply rule awslint:attribute-tag: Resource attribute properties should be tagged with "@Attribute"
  • Implement and apply rule awslint:attribute-name: Resource attribute properties should begin with the type name ("bucketArn" instead of "arn")
  • Implement and apply rule awslint:attribute-name-tag: If a property starts with "bucket", it must be a resource attribute
  • Implement and apply rule awslint:attribute-readonly: Resource attribute properties must be readonly
  • Implement and apply rule awslint:attribute-type: Resource attributes should have a "string" or "string[]" type
  • Implement and apply rule awslint:attribute-doc-returns-token: Resource attribute jsdocs should include text that indicates this is an opaque token
@eladb eladb added package/awscl Cross-cutting issues related to the AWS Construct Library effort/small Small work item – less than a day of effort labels Apr 15, 2019
@eladb
Copy link
Contributor Author

eladb commented May 1, 2019

Split into multiple issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort package/awscl Cross-cutting issues related to the AWS Construct Library
Projects
None yet
Development

No branches or pull requests

1 participant