Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guidelines implementation: Imports #2273

Closed
3 tasks
eladb opened this issue Apr 15, 2019 · 1 comment
Closed
3 tasks

Guidelines implementation: Imports #2273

eladb opened this issue Apr 15, 2019 · 1 comment
Assignees
@eladb
Labels
effort/medium Medium work item – several days of effort package/awscl Cross-cutting issues related to the AWS Construct Library

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019 •
edited
Loading

  • Implement and apply rule awslint:from-signature: All fromXxx static methods should accept "scope, string[, props]" and return IFoo
  • Implement and apply rule awslint:from-attributes: Constructs should have at least one "fromXxx" static method that is not "fromExport", no type name prefix
  • Implement and apply rule awslint:from-account: The last argument of the fromAccount method should begin with QueryXxxx
@eladb eladb added the package/awscl Cross-cutting issues related to the AWS Construct Library label Apr 15, 2019
@eladb eladb changed the title Guidelines implementation: imports/exports Guidelines implementation: Imports/Exports Apr 15, 2019
@eladb eladb mentioned this issue Apr 15, 2019
Closed
@eladb eladb added effort/large Large work item – several weeks of effort effort/medium Medium work item – several days of effort and removed effort/large Large work item – several weeks of effort labels Apr 15, 2019
@eladb eladb changed the title Guidelines implementation: Imports/Exports Guidelines implementation: Imports Apr 16, 2019
@eladb eladb mentioned this issue Apr 16, 2019
Closed
@eladb
Copy link
Contributor Author

eladb commented May 1, 2019

Split into multiple issues

@eladb eladb closed this as completed May 1, 2019
@girotomas girotomas mentioned this issue May 30, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
effort/medium Medium work item – several days of effort package/awscl Cross-cutting issues related to the AWS Construct Library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eladb