Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

think about this: Revert capitalization of L1 properties to original pascal case #2291

Closed
eladb opened this issue Apr 15, 2019 · 1 comment
Closed

think about this: Revert capitalization of L1 properties to original pascal case #2291

eladb opened this issue Apr 15, 2019 · 1 comment
Labels
package/awscl Cross-cutting issues related to the AWS Construct Library package/cfn Related to the CFN layer (L1)

Comments

@eladb
Copy link
Contributor

eladb commented Apr 15, 2019

Should we revert the camel case capitalization and use the original pascal case in L2 props?

  • cdk-dasm work exposed an issue around the current model because it's hard to tell which parts of the template schema are capitalized and which are not (i.e. IAM policies are not).
  • jsii languages currently rely on the naming conventions in order to be able to translate names across languages
@eladb eladb added the package/cfn Related to the CFN layer (L1) label Apr 15, 2019
@eladb eladb changed the title think this: Revert capitalization of L1 properties to original pascal case think about this: Revert capitalization of L1 properties to original pascal case Apr 15, 2019
@eladb eladb added package/awscl Cross-cutting issues related to the AWS Construct Library and removed package/awscl Cross-cutting issues related to the AWS Construct Library labels May 1, 2019
@eladb eladb closed this as completed May 14, 2019
@eladb eladb reopened this May 14, 2019
@eladb
Copy link
Contributor Author

eladb commented May 30, 2019

Due to risks related to jsii case conversions, I think we shouldn't do this. Closing for now. Anyone is welcome to reopen if they want to discuss further.

@eladb eladb closed this as completed May 30, 2019
@sumodgeorge sumodgeorge mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package/awscl Cross-cutting issues related to the AWS Construct Library package/cfn Related to the CFN layer (L1)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eladb