feat(apigatewayv2): allow websockets routes to return response to client

[emilrowland]

This PR allows WebSocket routes to return a response to the client.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[emilrowland]

I had to add an integration test to aws-apigatewayv2-integrations as I couldn't use a Mock integration in aws-apigatewayv2.
This is due to dependency conflicts.

[TheRealAmazonKendra]

Thank you for your contribution! Please see my comments inline.

[TheRealAmazonKendra]

Given that the way this is being used when it is true, I'm not sure that boolean is the right value here. You're adding $default as the routeResponseSelectionExpression creating a whole object from this . Can you help me understand why a boolean here is the right user experience?

[emilrowland]

Today the only valid value o the routeResponseSelectionExpression is $default or undefined. So to not overcomplicate it by passing a string I abstracted it to be a boolean instead.

See the quote below from https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-websocket-api-selection-expressions.html

Evaluation of the route response selection expression produces a route response key. Eventually, this key will be used to choose from one of the RouteResponses associated with the API. However, currently only the $default key is supported.

But if we want to be more future proof we could change the attribute to be the actual routeResponseSelectionExpression and pass it a string.

Pull request has been modified.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[TheRealAmazonKendra]

@Mergifyio update

[mergify]

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/close-stale-issues.yml without workflows permission
err-code: 77C13

[comcalvi]

lgtm, leaving do-not-merge so @TheRealAmazonKendra can take a look

[TheRealAmazonKendra]

@Mergifyio update

[mergify]

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/issue-label-assign.yml without workflows permission
err-code: 8D750

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: bd49362
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).