Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case of a missing PR for k8s v1.24 #23139

Closed
robertd opened this issue Nov 29, 2022 · 3 comments
Closed

Case of a missing PR for k8s v1.24 #23139

robertd opened this issue Nov 29, 2022 · 3 comments
Assignees
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. package/tools Related to AWS CDK Tools or CLI

Comments

@robertd
Copy link
Contributor

robertd commented Nov 29, 2022

Describe the bug

I noticed that my PR (#22945) got approved & merged in few days ago, but it never really got merged in back into main and released.

Any ideas what happened? Did my PR hit an edge case or something?

cc @kaizencc @rix0rrr @pahud

Expected Behavior

My PR should've been merged in properly.

Current Behavior

My PR is missing from the main brranch.

Reproduction Steps

N/A

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.53.0

Framework Version

No response

Node.js Version

18.2.0

OS

OSx

Language

Typescript

Language Version

No response

Other information

No response

@robertd robertd added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Nov 29, 2022
@robertd robertd changed the title (module name): (short issue description) Case of a missing PR for k8s v1.24 Nov 29, 2022
@kaizencc
Copy link
Contributor

Hi @robertd, the commit is here: cc957d6

You're probably concerned that our latest releases do not include it. That is because we are only releasing re:invent critical features at the moment. Things should resume as normal next week and your commit should be released then.

@robertd
Copy link
Contributor Author

robertd commented Nov 29, 2022

Ah… code freeze. I forgot about it. That’s makes perfect sense. Thanks @kaizencc.

@robertd robertd closed this as completed Nov 29, 2022
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

3 participants