fix(apigateway): allow multi-level base path mapping #23362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update base path mapping validations to allow multi-level base path mappings. Base path mapping cannot start or end with slash and cannot contain consecutive slashes.
|
|
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Dec 15, 2022
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
comcalvi
previously requested changes
Dec 15, 2022
packages/@aws-cdk/aws-apigateway/test/integ.base-path-mapping.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-apigateway/test/base-path-mapping.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-apigateway/test/base-path-mapping.test.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-apigateway/test/base-path-mapping.test.ts
Outdated
Show resolved
Hide resolved
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
VarunWachaspati
requested review from
comcalvi and
aws-cdk-automation
and removed request for
aws-cdk-automation and
comcalvi
comcalvi
approved these changes
Dec 17, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Jan 20, 2023
API Gateway allows multi-level base path mapping but CDK doesn't support the same yet. ([AWS Announcement Post](https://aws.amazon.com/about-aws/whats-new/2021/03/amazon-api-gateway-custom-domain-names-support-multi-level-base-path-mappings/)) Also, added new base path mapping validations such as shouldn't start or end with `/` or shouldn't contain consecutive `/`. fixes aws#23347 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
brennanho
pushed a commit
to brennanho/aws-cdk
that referenced
this pull request
Feb 22, 2023
API Gateway allows multi-level base path mapping but CDK doesn't support the same yet. ([AWS Announcement Post](https://aws.amazon.com/about-aws/whats-new/2021/03/amazon-api-gateway-custom-domain-names-support-multi-level-base-path-mappings/)) Also, added new base path mapping validations such as shouldn't start or end with `/` or shouldn't contain consecutive `/`. fixes aws#23347 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Construct Runtime Dependencies: * [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Gateway allows multi-level base path mapping but CDK doesn't support the same yet. (AWS Announcement Post)
Also, added new base path mapping validations such as shouldn't start or end with
/or shouldn't contain consecutive/.fixes #23347
All Submissions:
Adding new Construct Runtime Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license