Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apprunner): apprunner secrets manager #23692

Merged
merged 15 commits into from
Jan 19, 2023
Merged

feat(apprunner): apprunner secrets manager #23692

merged 15 commits into from
Jan 19, 2023

Conversation

KarlDeux
Copy link
Contributor

@KarlDeux KarlDeux commented Jan 15, 2023 •
edited
Loading

All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 15, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 15, 2023 16:57
@mergify mergify bot mentioned this pull request Jan 15, 2023
Closed
4 tasks
@gitpod-io
Copy link

gitpod-io bot commented Jan 16, 2023

rix0rrr
rix0rrr previously requested changes Jan 17, 2023
View reviewed changes
packages/@aws-cdk/aws-apprunner/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apprunner/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apprunner/lib/service.ts Show resolved Hide resolved
@rix0rrr rix0rrr self-assigned this Jan 17, 2023
@mergify mergify bot dismissed rix0rrr’s stale review January 17, 2023 13:44

Pull request has been modified.

@KarlDeux KarlDeux requested a review from rix0rrr January 18, 2023 18:16
rix0rrr
rix0rrr previously requested changes Jan 19, 2023
View reviewed changes
packages/@aws-cdk/aws-apprunner/lib/service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apprunner/lib/service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apprunner/lib/service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-apprunner/lib/service.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed rix0rrr’s stale review January 19, 2023 11:58

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: db70eb9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 19, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a914fc0 into aws:main Jan 19, 2023
@hariohmprasath hariohmprasath mentioned this pull request Jan 23, 2023
Closed
@KarlDeux KarlDeux deleted the apprunner-secrets-manager branch January 23, 2023 10:30
@KarlDeux KarlDeux restored the apprunner-secrets-manager branch January 23, 2023 16:32
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KarlDeux @aws-cdk-automation @rix0rrr