Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redshift): IAM roles can be attached to a cluster, post creation #23791

Merged
merged 27 commits into from
Feb 10, 2023
Merged

feat(redshift): IAM roles can be attached to a cluster, post creation #23791

merged 27 commits into from
Feb 10, 2023

Conversation

Rizxcviii
Copy link
Contributor

@Rizxcviii Rizxcviii commented Jan 23, 2023 •
edited
Loading

Created an addIamRole method that will allow attaching an IAM role to a cluster, post its creation.
closes #22632

All Submissions:

Adding new Construct Runtime Dependencies:

  • This PR adds new construct runtime dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 23, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team January 23, 2023 16:17
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Jan 23, 2023
@Rizxcviii Rizxcviii changed the title Feature/add iam role after declaration feat(redshift): adding method for attaching IAM roles to redshift cluster, after cluster creation Jan 23, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@Rizxcviii Rizxcviii changed the title feat(redshift): adding method for attaching IAM roles to redshift cluster, after cluster creation feat(redshift): add method that adds IAM role to cluster, post creation Jan 23, 2023
@Rizxcviii Rizxcviii changed the title feat(redshift): add method that adds IAM role to cluster, post creation feat(redshift): add method that attaches IAM role to cluster, post creation Jan 23, 2023
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels Jan 23, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 23, 2023 16:36

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@Rizxcviii Rizxcviii changed the title feat(redshift): add method that attaches IAM role to cluster, post creation feat(redshift): IAM roles can be attached to a cluster, post creation Jan 23, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 30, 2023 10:44

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

comcalvi
comcalvi previously requested changes Feb 1, 2023
View reviewed changes
packages/@aws-cdk/aws-redshift/lib/cluster.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed comcalvi’s stale review February 1, 2023 12:55

Pull request has been modified.

@Rizxcviii Rizxcviii requested a review from comcalvi February 2, 2023 16:24
comcalvi
comcalvi previously requested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment and this should be ready to merge

packages/@aws-cdk/aws-redshift/lib/cluster.ts Show resolved Hide resolved
packages/@aws-cdk/aws-redshift/lib/cluster.ts Outdated Show resolved Hide resolved
@mergify mergify bot dismissed comcalvi’s stale review February 9, 2023 11:00

Pull request has been modified.

@Rizxcviii Rizxcviii requested a review from comcalvi February 9, 2023 11:40
@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8ec3caf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1a46808 into aws:main Feb 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Rizxcviii Rizxcviii deleted the feature/add-iam-role-after-declaration branch February 10, 2023 09:53
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comcalvi comcalvi comcalvi approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-redshift-alpha: create method that adds IAM role to cluster
3 participants
@Rizxcviii @aws-cdk-automation @comcalvi