Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(msk): add Kafka version 3.3.2 #24440

Merged
merged 5 commits into from
Mar 7, 2023
Merged

feat(msk): add Kafka version 3.3.2 #24440

merged 5 commits into from
Mar 7, 2023

Conversation

stefanfreitag
Copy link
Contributor

Add support for the MSK Kafka version 3.3.2.
The new version was announced on Mar 02 2023, the link to the announcement is in the linked issue.

Closes #24432 .

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 3, 2023
@stefanfreitag stefanfreitag changed the title feat(msk): add Kafka versions 3.3.2 feat(msk): add Kafka version 3.3.2 Mar 3, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 3, 2023 11:45
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@stefanfreitag
Copy link
Contributor Author

stefanfreitag commented Mar 3, 2023 •
edited
Loading

Exemption Request

Hi,
in my opinion this change does not require an update of the README.md file. It introduces a new entry in the KafkaVersions class and those entries are not documented in the README.
Please let me know if you are fine with this.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 3, 2023
@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Mar 4, 2023
kaizencc
kaizencc previously approved these changes Mar 4, 2023
View reviewed changes
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 4, 2023 02:06

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@stefanfreitag
Copy link
Contributor Author

@Mergifyio requeue

@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2023

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

  • sender-permission>=write

@stefanfreitag
Copy link
Contributor Author

@kaizencc Is it possible to re-trigger the code build job from your side? I had seen

[2/4] Fetching packages...
info There appears to be trouble with your network connection. Retrying...
error An unexpected error occurred: "https://registry.npmjs.org/typescript/-/typescript-3.9.10.tgz: unexpected end of file".

in the log files. Maybe something with the network.

@mergify mergify bot dismissed kaizencc’s stale review March 6, 2023 10:10

Pull request has been modified.

kaizencc
kaizencc previously approved these changes Mar 7, 2023
View reviewed changes
@mergify mergify bot dismissed kaizencc’s stale review March 7, 2023 16:33

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cecbb74
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 7, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1b2014e into aws:main Mar 7, 2023
@stefanfreitag stefanfreitag deleted the msk-3-3-2 branch March 10, 2023 07:56
homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
@stefanfreitag @homakk
feat(msk): add Kafka version 3.3.2 (aws#24440)
15f9769 
Add support for the MSK Kafka version 3.3.2.
The new version was announced on Mar 02 2023, the link to the announcement is in the linked issue.

Closes aws#24432 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(msk): add Kafka versions 3.3.2
3 participants
@stefanfreitag @aws-cdk-automation @kaizencc