Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): SSM sessions #24673

Merged
merged 2 commits into from
Mar 20, 2023
Merged

feat(ec2): SSM sessions #24673

merged 2 commits into from
Mar 20, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 17, 2023

It's not too hard to enable SSM Session Manager to Instances and AutoScalingGroups (it's a matter of picking the right AMI and adding the right managed policy to the instance role).

This PR adds a single boolean to turn on the policy directly and advertises the feature in the README for people who might otherwise not know this feature exists.

Also consistentize the use and explanation of MachineImage.latestAmazonLinux a bit.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

It's not too hard to enable SSM Session Manager to Instances and
AutoScalingGroups (it's a matter of picking the right AMI and
adding the right managed policy to the instance role).

This PR adds a single boolean to turn on the policy directly and
advertises the feature in the README for people who might otherwise not
know this feature exists.
@rix0rrr rix0rrr requested a review from a team March 17, 2023 19:07
@rix0rrr rix0rrr self-assigned this Mar 17, 2023
@github-actions github-actions bot added the p2 label Mar 17, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 17, 2023 19:07
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 17, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Mar 20, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 20, 2023 13:01

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8620fd3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9744a82 into main Mar 20, 2023
@mergify mergify bot deleted the huijbers/ssm-perms branch March 20, 2023 13:41
@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
It's not too hard to enable SSM Session Manager to Instances and AutoScalingGroups (it's a matter of picking the right AMI and adding the right managed policy to the instance role).

This PR adds a single boolean to turn on the policy directly and advertises the feature in the README for people who might otherwise not know this feature exists.

Also consistentize the use and explanation of `MachineImage.latestAmazonLinux` a bit.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants