Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-synthetics-alpha: missing latest python runtime definition (2.0) #24704

Closed
frichtarik opened this issue Mar 20, 2023 · 8 comments
Closed
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@frichtarik
Copy link
Contributor

frichtarik commented Mar 20, 2023

Describe the bug

selfexplanatory

Expected Behavior

python selenium runtimes including 2.0 should be available

Current Behavior

import { Runtime } from '@aws-cdk/aws-synthetics-alpha';

Runtime.SYNTHETICS_PYTHON_SELENIUM_2_0, is not available in SYNTHETICS_PYTHON_SELENIUM family

Reproduction Steps

new Canary(this, 'Canary', {
schedule: Schedule.rate(Duration.minutes(15)),
test: Test.custom({
code: Code.fromAsset(__dirname),
handler: 'index.handler',
}),
runtime: Runtime.SYNTHETICS_PYTHON_SELENIUM_2_0,
});

Possible Solution

I can see the definitions in repository but they are not built into alpha package

Additional Information/Context

No response

CDK CLI Version

2.100.0 (build 60a5b2a)
"@aws-cdk/aws-synthetics-alpha": "^2.100.0-alpha.0",

Framework Version

No response

Node.js Version

v18.17.1

OS

OSX 13.6 (22G120)

Language

Typescript

Language Version

TS 4.9.5

Other information

No response

@frichtarik frichtarik added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 20, 2023
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Mar 20, 2023
@frichtarik frichtarik changed the title aws-synthetics: missing latest python runtime definitions (anything more current than 1.0) aws-synthetics-alpha: missing latest python runtime definitions (anything more current than 1.0) Mar 20, 2023
@pahud
Copy link
Contributor

pahud commented Mar 20, 2023

Thank you. We can add this support in the Runtime class. Are you interested to submit a PR for that?

@pahud pahud added p2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 20, 2023
@frichtarik
Copy link
Contributor Author

@pahud yes but i don't understand what needs to be changed

those definitions are already in the runtime class in tag v2.69.0, i just don't understand why they are not available in the alpha package

@stefanfreitag
Copy link
Contributor

Hi @frichtarik,

I setup a new project based on cdk v2.69.0 and included the alpha package

deps: ['@aws-cdk/aws-synthetics-alpha@2.69.0-alpha.0']

My code is very basic and looks like

image

I can successfully do a synth. Below is the relevant part showing the v1.3 version usage

image

The list of offered versions contains v1.0 to v1.3:

image

@frichtarik
Copy link
Contributor Author

it works with 2.70.0 packages but did not and is not with 2.69.0

tried switching between them several times now to confirm

but the fact they are finally available with 2.70.0 fixes my issue, thanks for your time

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@frichtarik frichtarik reopened this Oct 12, 2023
@frichtarik frichtarik changed the title aws-synthetics-alpha: missing latest python runtime definitions (anything more current than 1.0) aws-synthetics-alpha: missing latest python runtime definition (2.0) Oct 12, 2023
@frichtarik
Copy link
Contributor Author

issue reoccured with selenium runtime 2.0

@kaizencc
Copy link
Contributor

best practice is to open a new issue for new feature requests: #27566

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

4 participants