fix(integ-runner): update workflow doesn't support resource replacement #24720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the update workflow we deploy the stack update with the `--no-rollback` flag so that the assertion stack will deploy all the way through instead of failing on the first assertion failure. This causes issues if you are deploying an update that includes resource replacement since resource replacement is not allowed when using `--no-rollback` To fix this, this PR splits the stack update deployment into two separate deployments. The first deploys the test case stack and the second deploys the assertion stack with `--no-rollback`.
TheRealAmazonKendra
approved these changes
Mar 27, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Mar 28, 2023
…nt (aws#24720) For the update workflow we deploy the stack update with the `--no-rollback` flag so that the assertion stack will deploy all the way through instead of failing on the first assertion failure. This causes issues if you are deploying an update that includes resource replacement since resource replacement is not allowed when using `--no-rollback` To fix this, this PR splits the stack update deployment into two separate deployments. The first deploys the test case stack and the second deploys the assertion stack with `--no-rollback`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the update workflow we deploy the stack update with the
--no-rollbackflag so that the assertion stack will deploy all the waythrough instead of failing on the first assertion failure. This causes
issues if you are deploying an update that includes resource
replacement since resource replacement is not allowed when using
--no-rollbackTo fix this, this PR splits the stack update deployment into two
separate deployments. The first deploys the test case stack and the
second deploys the assertion stack with
--no-rollback.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license