Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TransitGatewayAttachment: AWS::EC2::TransitGatewayAttachment ApplianceModeSupport options are named "applianceModeSupport" #24754

Closed
JPLemelin opened this issue Mar 22, 2023 · 2 comments
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud

Comments

@JPLemelin
Copy link

JPLemelin commented Mar 22, 2023

Describe the bug

After upgrading from 2.56.0 to 2.56.1, the CloudFormation attribute "ApplianceModeSupport" was rename with a lower case

Sample of construct usage:

const transitGatewayAttachmentVpc = new ec2.CfnTransitGatewayAttachment(this, 'tgw-att-vpc', {
  transitGatewayId: transitGateway.ref,
  vpcId: vpc.vpcId,
  subnetIds: vpc.selectSubnets({subnetGroupName: 'tgw-subnet'}).subnetIds,
  options: {
    applianceModeSupport: 'enable',
  },
}

Diff after upgrading

[~] AWS::EC2::TransitGatewayAttachment tgw-att-vpc tgwattvpc 
 └─ [~] Options
     ├─ [-] Removed: .ApplianceModeSupport
     └─ [+] Added: .applianceModeSupport

Expected Behavior

Cloudformation generated should be named accourding to the doc: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-transitgatewayvpcattachment-options.html#cfn-ec2-transitgatewayvpcattachment-options-appliancemodesupport

Current Behavior

The stack failed to deploy

The stack named hub-network failed to deploy: UPDATE_ROLLBACK_COMPLETE: Properties validation failed for resource tgwattvpc with message:
#/Options: extraneous key [applianceModeSupport] is not permitted

Reproduction Steps

Just execute cdk deploy cmd

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.56.1

Framework Version

No response

Node.js Version

16

OS

MacOs

Language

Typescript

Language Version

No response

Other information

No response

@JPLemelin JPLemelin added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 22, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud label Mar 22, 2023
@peterwoodworth
Copy link
Contributor

This is the same cause as the other issues I've named in this comment. tl;dr we got stuck between a rock and a hard place regarding typing of resources cfnspec changed. Going forward we're looking how to prevent this from happening again. In the meantime, you'll need to define the properties with capital letters

@peterwoodworth peterwoodworth removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 23, 2023
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ec2 Related to Amazon Elastic Compute Cloud
Projects
None yet
Development

No branches or pull requests

2 participants