-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(servicecatalogappregistry): Remove deprecated resource in Application Construct #25095
Conversation
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…*associateAttributeGroup** in Application Construct. The user who are using these two method need to update to use alternative method. For associateStack, the alternative method is **associateApplicationWithStack** For associateAttributeGroup, the alternative method is **AttributeGroup.associateWith** Purpose of this PR: we need to remove deprecated resource before we moving into stable version The method that we remove is: associateStack and associateAttributeGroup CHANGES: 1. in lib/application.ts, we remove these two methods and update their corresponding interface 2. in test/ application.test.ts & test/integ.application.ts, we update application.test.ts and integ.application.ts to remove these two methods' related test Testing done ------------------------------------- * yarn build * yarn test Related items ------------------------------------ * SIM/auto-cut ticket
By removing these two functions completely will mean these methods will never be available in any of the latest CDK version and if any customer wants to upgrade their CDK dependency, then they cant do that without changing the underlying code. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
BREAKING CHANGE: this change will deprecated associateStack and associateAttributeGroup in Application Construct.
The user who are using these two method need to update to use alternative method.
For associateStack, the alternative method is associateApplicationWithStack
For associateAttributeGroup, the alternative method is AttributeGroup.associateWith
The user who are using these two method need to update to use alternative method. For associateStack, the alternative method is associateApplicationWithStack For associateAttributeGroup, the alternative method is AttributeGroup.associateWith
Purpose of this PR:
we need to remove deprecated resource before we moving into stable version The method that we remove is: associateStack and associateAttributeGroup
CHANGES:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license