Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(servicecatalogappregistry): Remove deprecated resource in Application Construct #25095

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

yingdon-amazon
Copy link
Contributor

BREAKING CHANGE: this change will deprecated associateStack and associateAttributeGroup in Application Construct.
The user who are using these two method need to update to use alternative method.
For associateStack, the alternative method is associateApplicationWithStack
For associateAttributeGroup, the alternative method is AttributeGroup.associateWith

The user who are using these two method need to update to use alternative method. For associateStack, the alternative method is associateApplicationWithStack For associateAttributeGroup, the alternative method is AttributeGroup.associateWith

Purpose of this PR:

we need to remove deprecated resource before we moving into stable version The method that we remove is: associateStack and associateAttributeGroup

CHANGES:

  1. in lib/application.ts, we remove these two methods and update their corresponding interface
  2. in test/ application.test.ts & test/integ.application.ts, we update application.test.ts and integ.application.ts to remove these two methods' related test

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Apr 13, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 13, 2023 00:42
@github-actions github-actions bot added the p2 label Apr 13, 2023
rix0rrr
rix0rrr previously approved these changes Apr 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…*associateAttributeGroup** in Application Construct.

The user who are using these two method need to update to use alternative method.
For associateStack, the alternative method is **associateApplicationWithStack**
For associateAttributeGroup, the alternative method is **AttributeGroup.associateWith**

Purpose of this PR:

we need to remove deprecated resource before we moving into stable version The method that we remove is: associateStack and associateAttributeGroup

CHANGES:

1. in lib/application.ts, we remove these two methods and update their corresponding interface
2. in test/ application.test.ts & test/integ.application.ts, we update application.test.ts and integ.application.ts to remove these two methods' related test

Testing done
-------------------------------------
* yarn build
* yarn test
Related items
------------------------------------
* SIM/auto-cut ticket
@mergify mergify bot dismissed rix0rrr’s stale review April 14, 2023 17:41

Pull request has been modified.

@santanugho
Copy link
Contributor

associateStack and associateAttributeGroup is already available in the main branch for cdk v1.
Check this code which is using associateStack from the main branch.

By removing these two functions completely will mean these methods will never be available in any of the latest CDK version and if any customer wants to upgrade their CDK dependency, then they cant do that without changing the underlying code.

@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1978c96
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 9222f21 into aws:main Apr 17, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 17, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

yingdon-amazon added a commit to yingdon-amazon/aws-cdk that referenced this pull request Apr 17, 2023
yingdon-amazon added a commit to yingdon-amazon/aws-cdk that referenced this pull request Apr 17, 2023
yingdon-amazon added a commit to yingdon-amazon/aws-cdk that referenced this pull request May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants